Skip to content

theme song / theme videos volume adjustments #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
throwabird opened this issue Oct 22, 2021 · 3 comments · May be fixed by #6674
Open

theme song / theme videos volume adjustments #3086

throwabird opened this issue Oct 22, 2021 · 3 comments · May be fixed by #6674
Labels
enhancement Improve existing functionality or small fixes

Comments

@throwabird
Copy link

Currently when a theme song is playing in the background you have no way to control the volume it is playing at. When using Syncplay a Playback Control Bar appears and you can pause, play, skip and adjust the volume as described in #2918 and #3059.

I think it would be worth having an option to always display the Playback Control Bar when the theme song / theme video is playing especially since jellyfin/jellyfin#537 is not yet implemented and it is not uncommon for different theme songs to have completely different volumes. Alternatively a less noticeable / intrusive volume control such as the one during video playback when using the arrow keys (just display when adjustments are made) could be considered.

I am hoping to get some different opinions on this topic.
@throwabird throwabird added the enhancement Improve existing functionality or small fixes label Oct 22, 2021
@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Oct 24, 2021 •
edited
Loading

#2028 (comment)
I just thought. If we hide nowPlayingBar, we cannot change volume (other controls are less usable for theme song).
Keyboard media buttons (volume-related) can be handled in scripts/keyboardNavigation.js.
TVs (real ones) have a physical volume control - no problem.
But what about mouse users?

As an additional idea, we could add volume option next to the theme-related checkboxes in Display user settings - just like Music volume in games. Then use it to suppress theme songs volume.

In addition, the plan was to add key bindings on the Controls page in the user settings (#2532).
Probably for each state: browsing, playback.
No one is currently implementing this feature.

@adripo
Copy link

adripo commented Apr 17, 2024

Hello, is there any plan to address this feature request in the near future?

@adripo adripo mentioned this issue May 29, 2024
Closed
@XurxoMF

This comment has been minimized.

Sign in to view
This was referenced Mar 28, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
No milestone
4 participants
@adripo @dmitrylyzo @XurxoMF @throwabird