Skip to content

Update subtitle position styling #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Apr 14, 2025

Changes

  • Updates the positioning of subtitles when they are bottom aligned to maintain a constant spacing from the bottom of the screen

Single Line

position current updated
-4
-3 line 1 line 1
-2
-1

Two Lines

position current updated
-4 line 1
-3 line 1 line 2
-2 line 2
-1

Four Lines

position current updated
-6 line 1
-5 line 2
-4 line 1 line 3
-3 line 2 line 4
-2 line 3
-1 line 4

Issues
https://features.jellyfin.org/posts/3210/subtitle-position-correction-adjustment-line-1-2

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Apr 14, 2025
@thornbill thornbill added this to the v10.11.0 milestone Apr 14, 2025
@thornbill thornbill requested a review from a team as a code owner April 14, 2025 16:11
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Apr 14, 2025

Cloudflare Pages deployment

Latest commit 0f47c95
Status ✅ Deployed!
Preview URL https://d7a1b4ba.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Apr 14, 2025

Do native subtitles (Chrome) work the same way?

const cueLine = parseInt(subtitleAppearance.verticalPosition, 10);

UPD: It uses old behavior.
Native:

simplescreenrecorder.mp4

@thornbill
Copy link
Member Author

Good catch @dmitrylyzo! This should be working in both cases now. I also adjusted the values since my previous change left you unable to position the subtitles at the very bottom of the screen.

Copy link

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@thornbill thornbill merged commit abfc14d into jellyfin:master Apr 22, 2025
15 checks passed
@thornbill thornbill deleted the subtitle-position branch April 22, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants