Skip to content

Commit 3965f49

Browse files
authored
Resolve datetime deprecation warnings (#1528)
# PR Summary This small PR resolves the `datetime` deprecation warnings by replacing `utcfromtimestamp()` with `fromtimestamp()` and solving: ```python /home/runner/work/dulwich/dulwich/tests/test_objects.py:620: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). ``` Which you can see in the [CI logs](https://github.com/jelmer/dulwich/actions/runs/14574702612/job/40878265958#step:13:18).
2 parents 919212c + 1dcda6b commit 3965f49

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

tests/test_objects.py

+14-4
Original file line numberDiff line numberDiff line change
@@ -617,11 +617,17 @@ def test_simple(self) -> None:
617617
)
618618
expected_time = datetime.datetime(2007, 3, 24, 22, 1, 59)
619619
self.assertEqual(
620-
expected_time, datetime.datetime.utcfromtimestamp(c.commit_time)
620+
expected_time,
621+
datetime.datetime.fromtimestamp(
622+
c.commit_time, datetime.timezone.utc
623+
).replace(tzinfo=None),
621624
)
622625
self.assertEqual(0, c.commit_timezone)
623626
self.assertEqual(
624-
expected_time, datetime.datetime.utcfromtimestamp(c.author_time)
627+
expected_time,
628+
datetime.datetime.fromtimestamp(
629+
c.author_time, datetime.timezone.utc
630+
).replace(tzinfo=None),
625631
)
626632
self.assertEqual(0, c.author_timezone)
627633
self.assertEqual(None, c.encoding)
@@ -1139,7 +1145,9 @@ def test_parse(self) -> None:
11391145
self.assertEqual(b"a38d6181ff27824c79fc7df825164a212eff6a3f", object_sha)
11401146
self.assertEqual(Commit, object_type)
11411147
self.assertEqual(
1142-
datetime.datetime.utcfromtimestamp(x.tag_time),
1148+
datetime.datetime.fromtimestamp(x.tag_time, datetime.timezone.utc).replace(
1149+
tzinfo=None
1150+
),
11431151
datetime.datetime(2007, 7, 1, 19, 54, 34),
11441152
)
11451153
self.assertEqual(-25200, x.tag_timezone)
@@ -1159,7 +1167,9 @@ def test_parse_no_message(self) -> None:
11591167
b"Linus Torvalds <torvalds@woody.linux-foundation.org>", x.tagger
11601168
)
11611169
self.assertEqual(
1162-
datetime.datetime.utcfromtimestamp(x.tag_time),
1170+
datetime.datetime.fromtimestamp(x.tag_time, datetime.timezone.utc).replace(
1171+
tzinfo=None
1172+
),
11631173
datetime.datetime(2007, 7, 1, 19, 54, 34),
11641174
)
11651175
self.assertEqual(-25200, x.tag_timezone)

0 commit comments

Comments
 (0)