-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize Thank You Note on Plugins Page to Match Root & Downloads Page #2124
Comments
May I ask why is this an issue? What is your motivation? |
I thought it would be nice to have the thank you note appear the same on all pages. In the Root page In the Plugins page Thus I thought I can work on this issue to make sure the thank you note appears consistent across all the pages. |
Can you update the one on the jenkins.io website to match the one in the current plugin site's implementation, please? |
Why are you changing the original design in your implementation? |
Sure I shall make the changes. |
I tried to replicate the thank you note in Contributor Spotlight while I was implementing the thank you note in the root page. Thus I felt if 3 pages in jenkins.io have the same thank you note then the Plugins site can also have a similar one. So I came up with this issue and changed the implementation. |
@krisstern since you have asked me to change the design to be similar to the one in Plugins site. Shall I make similar changes in the Contributor Spotlight page as well? So that it has the same design as in Plugins site. Will that be necessary? Please let me know. This will ensure the thank you note design is the same on all the jenkins.io pages. |
Please leave the one in the Contributor Spotlight alone. That one has the exact same design as the one in the Plugins site. |
Also, I would appreciate it if you could discuss these things with me first before you submit a pull request, since I was the person who asked you to help with the implementation at first. |
Sure I shall adhere to your instructions. |
@krisstern First of all, thank you for trusting me with this task. I am sorry for the inconvenience caused. |
The Thank You note at the end of the Plugins page on Jenkins.io is different from the ones on the Root page and Downloads page. To ensure consistency, it should be updated to match the format used on the other pages.
I want to work on this issue.
The text was updated successfully, but these errors were encountered: