Skip to content

Add possibility to disable send any build notification to bitbucket #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

33man
Copy link

@33man 33man commented May 10, 2022

This PR add the feature to disable notification sending to bitbucket via BitbucketBuildStatusNotificationsTrait

We basically have our own Jenkins pipeline with custom notification steps and this plugin send duplicates notifications and sometime not accurate build status. (Maybe fixed with #472 but still will end up with multiple notifications in Bitbucket Builds)

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@KalleOlaviNiemitalo
Copy link
Contributor

Isn't this already doable with Skip Notifications Trait Plugin? See JENKINS-49216 / JENKINS-49471 / JENKINS-36755.

@KalleOlaviNiemitalo
Copy link
Contributor

Moreover, if this PR were merged, then it might cause Skip Notifications Trait Plugin to stop working, depending on the order in which the traits are evaluated.

@33man
Copy link
Author

33man commented May 11, 2022

Hello @KalleOlaviNiemitalo, Thanks for your comments. Indeed i wasn't aware of such extension. Sorry, i will therefore close the PR.

@33man 33man closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants