Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused file and CSS selectors #266

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 16, 2023

ClickHandler.js is no longer used/nor loaded anywhere, nor are the related CSS selectors. Was previously used in #169 but the method of copying URLs was replaced in #222.

Testing done

  • Plugin works as before

Submitter checklist

Preview Give feedback

@janfaracik janfaracik requested a review from a team as a code owner December 16, 2023 11:49
@MarkEWaite MarkEWaite added the bug Incorrect or flawed behavior label Dec 16, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I interactively tested the copy and paste and the presentation with the default theme and with the dark theme. It worked as expected with my Jenkins controller over https.

@MarkEWaite MarkEWaite merged commit 428d676 into jenkinsci:master Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or flawed behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants