Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70464] Test BuildParameterResolverExtensionTest #286

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

abhishekmaity
Copy link
Contributor

In response to #114,

Testing done

  • added BuildParameterResolverExtensionTest.java
  • Test coverage shown below

Screenshot 2024-01-26 161753

Submitter checklist

Preview Give feedback

@abhishekmaity abhishekmaity requested a review from a team as a code owner January 26, 2024 11:02
@github-actions github-actions bot added the tests Automated test addition or improvement label Jan 26, 2024
abhishekmaity and others added 3 commits January 26, 2024 16:45
The defaultValue was the same as the value returned by the
CustomObject class, so it was not clear which result was being
returned.

Changed the return value from the CustomObject class to be clearly
different from the default value.
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great pull request @abhishekmaity . Thanks very much! The coverage improvement is very nice.

I modified the last test in the suite with c7ca01f to make it more clear that the return value is provided by the CustomObject and not from the default value string included in the parameter definition.

Does that change make sense to you @abhishekmaity?

@abhishekmaity
Copy link
Contributor Author

This is a great pull request @abhishekmaity . Thanks very much! The coverage improvement is very nice.

I modified the last test in the suite with c7ca01f to make it more clear that the return value is provided by the CustomObject and not from the default value string included in the parameter definition.

Does that change make sense to you @abhishekmaity?

@MarkEWaite It brings more clarity and I'm okay with it. Thanks for improvising the PR.

@MarkEWaite MarkEWaite merged commit 98bd706 into jenkinsci:master Jan 26, 2024
17 checks passed
@abhishekmaity abhishekmaity deleted the test-case-1 branch January 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants