-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve incorrect badge examples when opened directly from URL #290
Conversation
@MarkEWaite If possible Can you review this? |
Thanks for the ping @sridamul . I have several other things that need my attention before I leave next week for several weeks of vacation. I'm not sure that I'll have time to review this before mid March. |
Hey @MarkEWaite, Can you review this now? |
Not yet @sridamul . Other things are needing my attention this week. I may be able to review it next week |
Hey @MarkEWaite Just a reminder ping to review this PR. |
Thanks very much for the fix. I introduced the bug when I added a copy button for the link examples and transitioned from defining the pages with groovy to defining them with jelly. Jelly is more widely used for page definition in Jenkins than groovy and has better support for the most recent user interface updates. The pull request that created the issue was: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the fix!
Closes #278
Approach:
Replaced the
getReferer()
method withgetRequestURL()
(I am not sure if it is the optimal way to do it, but it fixes the issue without any flaws). Also modified the test cases to use getRequestURL() with and withoutbadge/
at the end of the URL.Testing done
Before:

Now:
wdyt.mp4
Submitter checklist