Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 469 default exchange setting websocket message #494

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BartStolarek
Copy link

These changes:

  1. Properly handle process termination
  2. Clean up Redis subscriptions
  3. Handle websocket disconnections more gracefully
  4. Ensure all resources are properly released
  5. Prevent the flood of error messages when closing tabs

The key improvement is that we're now handling the entire cleanup process systematically, ensuring that both the process and its associated resources (Redis subscriptions, websocket connections) are properly terminated.

Testing has not happened

@saleh-mir
Copy link
Member

Hey man, thank you for submitting this. What do you mean testing has not happened?

Also, may I ask how you wrote this? This is a very sensitive part of the source code. The AI return code for this type of thing looks very promising, but sometimes it breaks everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants