Render hyperlinks in last line of view if it doesn't end with a line feed #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feed Previously we would render hyperlinks only when seeing a newline; but for some views, the last line doesn't end in a newline (e.g. lazygit's confirmation panels), so hyperlinks were never rendered in the last line for those.
stefanhaller
added a commit
to jesseduffield/lazygit
that referenced
this pull request
Apr 3, 2025
jesseduffield
approved these changes
Apr 8, 2025
stefanhaller
added a commit
to jesseduffield/lazygit
that referenced
this pull request
Apr 8, 2025
This includes a fix to render hyperlinks in the last line of a view if it doesn't end with a line feed; see jesseduffield/gocui#77.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would render hyperlinks only when seeing a newline; but for some views, the last line doesn't end in a newline (e.g. lazygit's confirmation panels), so hyperlinks were never rendered in the last line for those.