Skip to content

[bug] osc 8 flooding #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phanen opened this issue Mar 24, 2025 · 2 comments
Open

[bug] osc 8 flooding #4421

phanen opened this issue Mar 24, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@phanen
Copy link

phanen commented Mar 24, 2025

Describe the bug

Too many osc8 requested to the terminal.

Using a neovim terminal (v0.10.0+) to reproduce (this command launch a lazygit in nvim terminal, and nvim will echo all terminal request in error level):

mkdir /tmp/tmp; cd /tmp/tmp; git init
nvim -u NONE +"au TermRequest * echoerr v:termrequest" +"term ./lazygit -ucf /dev/null"
# this way can check this without attach tui
# nvim --headless -u NONE +"au TermRequest * echoerr v:termrequest" +"term ./lazygit -ucf /dev/null"

Then hit enter and enter again and again, you will see endless ^[]8;;:

Image

I bisected and found this problem didn't exist before this: 524bf83.

Expected behavior
There shouldn't be too many OSC 8 request.

Additional context

  • neovim 0.10.0+
@phanen phanen added the bug Something isn't working label Mar 24, 2025
@phanen
Copy link
Author

phanen commented Mar 24, 2025

After debugging for a while, I found this seems a upstream problem...

524bf83 cause this by bump tcell (v2.5.1 -> v2.5.2), which will tputs this on each drawcell:

// URL string can be long, so don't send it unless we really need to
if t.enterUrl != "" && t.curstyle != style {
if style.url != "" {
t.TPuts(ti.TParm(t.enterUrl, style.url, style.urlId))
} else {
t.TPuts(t.exitUrl)
}
}

@phanen
Copy link
Author

phanen commented Mar 24, 2025

Related: gdamore/tcell#527.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant