Skip to content

Update move and copy commands target path description #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Update move and copy commands target path description #115

merged 3 commits into from
Apr 19, 2024

Conversation

guydelarea
Copy link
Contributor

Update the mv and cp commands target path descriptions with the --flat flag, and add examples of moving or copying artifacts to an absolute path.

Copy link

github-actions bot commented Apr 18, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@guydelarea
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
See my inline comments.

@@ -264,6 +264,13 @@ Copy all artifacts located under **/rabbit** in the **source-frog-repo** reposit
jf rt cp "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --props=Version=1.0
```

#### Example 4

Copy all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a bit hard to understand from the example description what the desired outcome is, I suggest adding a "before" and "after" example that demonstrates the outcome. Also, I'm not sure "to an absolute path" isn't fully clear, so I suggest rephrasing the entire description.

@@ -329,6 +336,14 @@ Move all artifacts located under **/rabbit** in the **source-frog-repo** reposit
jf rt mv "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --props=Version=1.0
```

#### Example 4

Move all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a bit hard to understand from the example description what the desired outcome is, I suggest adding a "before" and "after" example that demonstrates the outcome. Also, I'm not sure "to an absolute path" isn't fully clear, so I suggest rephrasing the entire description.

Move all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path.

```
jf rt cp "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --flat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cp" here should probably be replaced with "mv".

@eyalbe4 eyalbe4 self-requested a review April 19, 2024 02:14
@@ -266,7 +266,7 @@ jf rt cp "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --props=Version=1.

#### Example 4

Copy all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path.
Copy all artifacts located under /rabbit in the **source-frog-repo** repository into the same path in the target-frog-repo repository without maintaining the original subdirectory hierarchy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target-frog-repo --> target-frog-repo
(Notice the markdown ** wrapping)

The same goes for the mv command example.

@eyalbe4 eyalbe4 self-requested a review April 19, 2024 05:03
@eyalbe4 eyalbe4 merged commit 0ed3a84 into jfrog:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants