-
Notifications
You must be signed in to change notification settings - Fork 54
Update move and copy commands target path description #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g and adding examples
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
See my inline comments.
@@ -264,6 +264,13 @@ Copy all artifacts located under **/rabbit** in the **source-frog-repo** reposit | |||
jf rt cp "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --props=Version=1.0 | |||
``` | |||
|
|||
#### Example 4 | |||
|
|||
Copy all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a bit hard to understand from the example description what the desired outcome is, I suggest adding a "before" and "after" example that demonstrates the outcome. Also, I'm not sure "to an absolute path" isn't fully clear, so I suggest rephrasing the entire description.
@@ -329,6 +336,14 @@ Move all artifacts located under **/rabbit** in the **source-frog-repo** reposit | |||
jf rt mv "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --props=Version=1.0 | |||
``` | |||
|
|||
#### Example 4 | |||
|
|||
Move all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a bit hard to understand from the example description what the desired outcome is, I suggest adding a "before" and "after" example that demonstrates the outcome. Also, I'm not sure "to an absolute path" isn't fully clear, so I suggest rephrasing the entire description.
Move all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path. | ||
|
||
``` | ||
jf rt cp "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --flat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cp" here should probably be replaced with "mv".
@@ -266,7 +266,7 @@ jf rt cp "source-frog-repo/rabbit/*" target-frog-repo/rabbit/ --props=Version=1. | |||
|
|||
#### Example 4 | |||
|
|||
Copy all artifacts located under /rabbit in the **source-frog-repo** repository to an absulote path. | |||
Copy all artifacts located under /rabbit in the **source-frog-repo** repository into the same path in the target-frog-repo repository without maintaining the original subdirectory hierarchy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target-frog-repo --> target-frog-repo
(Notice the markdown ** wrapping)
The same goes for the mv command example.
Update the mv and cp commands target path descriptions with the --flat flag, and add examples of moving or copying artifacts to an absolute path.