Skip to content

Add CLI Command Summaries docs #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 29, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented May 23, 2024

Added docs to explain the command summaries feature in the CLI.

@EyalDelarea EyalDelarea requested a review from eyalbe4 May 23, 2024 11:29
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful documentation.
You'll need to reference this new page from the SUMMARY.md file, which creates the table of contents.
See my initial comments. I'd like to review this PR again following the implementation of the comments.

@EyalDelarea EyalDelarea requested a review from eyalbe4 May 26, 2024 08:14
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline coments.

I think that this page uses emojis accessibly. Let's reduce the usage of emojs, and make this page have the same usage level as the other pages as part of JFrog CLI's documentation. Keep in mind this page isn't a standalone page, and it should remain consistent with the rest of the documentation.

I would like to review this PR once more, following the implementation of my comments.

@EyalDelarea EyalDelarea requested a review from eyalbe4 May 28, 2024 11:01
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Command Summaries" should be marked as bold, but not the word "The" -
image

@EyalDelarea EyalDelarea changed the title Add CLI command summary docs Add CLI Command Summaries docs May 29, 2024
@EyalDelarea EyalDelarea merged commit 12e171b into jfrog:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants