This repository was archived by the owner on May 15, 2018. It is now read-only.
Covert the runner constructor to a builder API #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the API of std::process::Command, and provides more flexible access to the handles for stdout and stderr than the previous iteration of the API.
The profile has to be kept alive over the lifetime of the process.
Repository owner
deleted a comment from
vijoyp
Jan 10, 2018
andreastt
approved these changes
Jan 10, 2018
There was a problem hiding this comment.
It looks like you have addressed my original concerns here.
I do agree with your assessment that we should land this in m-c so we can be a bit more confident it actually works, however.
@jgraham Are you happy if I go ahead and put the master branch of this repo in central as it is, then you resubmit this as a patch there? I think that will get us the best sort of test coverage.
|
Sure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @andreastt
This change is