Cannot use loop in actions_v2 variable

[BenjaminVouillaume]

Hello 👋

I just upgraded to version 0.14.3, and I'm trying to migrate from actions to actions_v2 in the sentry_issue_alert resource.

I change this code:

actions = jsonencode([
    for slack_notif in local.slack_notifs:
    {
      id         = "sentry.integrations.slack.notify_action.SlackNotifyServiceAction"
      channel    = slack_notif.channel
      channel_id = slack_notif.channel_id
      workspace  = data.sentry_organization_integration.slack.id
      tags       = "${var.owner.slug},${var.project_id},${var.environment}"
    }
  ])

to this code:

actions_v2 = [ for slack_notif in local.slack_notifs :
    { slack_notify_service = {
        channel    = slack_notif.channel
        workspace  = data.sentry_organization_integration.slack.id
        tags       = ["${var.owner.slug}", "${var.project_id}", "${var.environment}"]
    }}
  ]

And when I'm trying to apply I have this error:

╷
│ Error: Value Conversion Error
│
│   with module.service.module.common_alerts_production.sentry_issue_alert.issue,
│   on ../../modules/common_alerts/issue.tf line 34, in resource "sentry_issue_alert" "issue":
│   34:   actions_v2 = [
│   35:   # for slack_notif in local.slack_notifs :
│   36:   for slack_notif in local.slack_notifs :
│   37:     { slack_notify_service = {
│   38:         channel    = slack_notif.channel
│   39:         workspace  = data.sentry_organization_integration.slack.id
│   40:         tags       = ["${var.owner.slug}", "${var.project_id}", "${var.environment}"]
│   41:     }}
│   42:   ]
│
│ An unexpected error was encountered trying to build a value. This is always an error in the provider. Please report the following to the provider developer:
│
│ Received unknown value, however the target type cannot handle unknown values. Use the corresponding `types` package type or a custom type that handles unknown values.
│
│ Path: actions_v2
│ Target Type: *[]provider.IssueAlertActionModel
│ Suggested Type: basetypes.ListValue

I guess it's not possible right now to dynamically build a list of actions in the actions_v2 params because of the types mistmatch.

Can you help me with this ? Or do you see another way to dynamically build the list with the right type ?

Thanks you very much !

[jianyuan]

Hi @BenjaminVouillaume, this is unexpected. Can you tell me what version of Terraform are you using?

[BenjaminVouillaume]

Hi @jianyuan,
We are using terraform 1.9.8 right now. We're planning to upgrade to 1.10.x in January.

Thanks

[nikolaik]

I have a similar issue when using conditions_v2 in a module and conditionally setting the value, similar to this:

conditions_v2 = var.some_var == "some_value" ? [{ first_seen_event = {} }] : [{ first_seen_event = {} }] 

this gives:

╷
│ Error: Value Conversion Error
│
│   with module.yolo.sentry_issue_alert.slack,
│   on project_alerts/main.tf line 13, in resource "sentry_issue_alert" "slack":
│   13:   conditions_v2 = var.some_var == "some_value" ? [{ first_seen_event = {} }] : [{ first_seen_event = {} }]
│
│ An unexpected error was encountered trying to build a value. This is always an error in the provider. Please report the following to the provider developer:
│
│ Received unknown value, however the target type cannot handle unknown values. Use the corresponding `types` package type or a custom type that handles unknown values.
│
│ Path: conditions_v2[0]
│ Target Type: provider.IssueAlertConditionModel
│ Suggested Type: basetypes.ObjectValue

Also a quick question on the design of the resource sentry_issue_alert. Could this issue be solved by moving to allow multiple condition, action and filter blocks?

[BenjaminVouillaume]

As suggest by @nikolaik, and compare to other Terraform Providers, I would expect to somethings like that:

conditions_v2 {
  first_seen_event {} 
}
conditions_v2 {
  regression_event {} 
}

filters_v2 {
  age_comparison {
    comparison_type = "older"
    value           = 10
    time            = "minute"
  }
}
filters_v2 {
  issue_occurrences {
    value = 10
  }
}

actions_v2 {
  notify_email {
    target_type      = "IssueOwners"
    fallthrough_type = "ActiveMembers"
  }
}
dynamic "actions_v2" {
  for channel in var.channels :
  content {
    slack_notify_service {
      workspace = data.sentry_organization_integration.slack.id
      channel   = actions_v2.value.channel
      tags      = ["environment", "level"]
      notes     = "Please <http://example.com|click here> for triage information"
    }
  }
}

This structure would allow us to use the dynamic block !
This is pretty much the same as the trigger parameter in the sentry_metric_alert resource.

Just a opinion. I really don't know the impact on the code. And I'm not a developer so I can't contribute easily myself.
Thanks for maintaining this provider !

[bmaluff-willdom]

Hi! I also have a similar issue when trying to use a sentry_issue_alert from version 0.14.3, I get the following conversion error:

Error: Value Conversion Error

  with module.sentry.sentry_issue_alert.this,
  on ../../terraform_modules/sentry/main.tf line 80, in resource "sentry_issue_alert" "this":
  80:   filters_v2 = try(each.value.filters_v2, null)

An unexpected error was encountered trying to build a value. This is always an error in the provider. Please report the following to
the provider developer:

Received unknown value, however the target type cannot handle unknown values. Use the corresponding `types` package type or a custom
type that handles unknown values.
 
Path: filters_v2
Target Type: *[]provider.IssueAlertFilterModel
Suggested Type: basetypes.ListValue

The module is implemented this way:
main.tf

resource "sentry_issue_alert" "this" {
  ...
  filters_v2 = local.sentry_issue_alert.filters_v2
}

local.tf

locals {
  sentry_issue_alert = {
    ...
    filters_v2 = [
      {},
      {},
    ]
  }
}

The same thing happens with conditions_v2 and actions_v2.
And also thanks for maintaining this provider!

[rowanmoul]

Encountered this issue today as well. Even wrapping my ternary expression in tolist did not help. I will have to stick with filters instead of filters_v2 for now.

[YassineElbouchaibi]

Encountering the same issue just now as well, will stick with the deprecated interface for now. This is with Terraform v1.11.2.

[hfagundesemed]

Hi @jianyuan, we've encountered the same issue today. Our current module does the following:

conditions_v2 = split("::", each.key)[1] == "foo" ? [ { event_frequency = { comparison_type = "count" value = 30 interval = "1m" } } ] : [ { event_frequency = { comparison_type = "count" value = 60 interval = "1m" } } ]

When we change the conditional clause of the ternary expressions to either true or false, it works as expected. Seems to be an issue while using logic itself. This is Terraform v1.11.4, with provider version v0.14.5.

[fcuello-fudo]

Hi @jianyuan would you be able to take a look soon? I just want to see how much effort should I put into work-around this.

[jianyuan]

Apologies I was away on annual leave. I can look into this later this week!