Refactor upstream API handling, and basically everything else as well #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need further rework if implementing the new API token auth option.
This saves so many small headaches and gives us proper type checking.
jinnatar
force-pushed
the
push-xzkwsnuvwlrl
branch
from
e5c03e6 to
f4520ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the internals have changed quite a bit, the output metrics are the same. Hopefully auth will also be a bit more stable!
There are however breaking UI changes, hence version bumping up to
v0.3.0:--urlhas been dropped in favor of--protect_host&--protect_port--(no)verify_sslallows use of self-signed certs, although not recommended.PROTECT_EXPORTER_