feat: Mark bridge unhealthy based on restart requests from endpoints

[bgrozev]

• ref: Simplify code, order alphabetically.
• feat: Keep track of number of endpoints on each Bridge.
• feat: Mark bridge unhealthy based on restart requests from endpoints

[codecov]

Codecov Report

Attention: Patch coverage is 41.96429% with 65 lines in your changes missing coverage. Please review.

Project coverage is 26.64%. Comparing base (7431511) to head (61e2dc1).
Report is 25 commits behind head on master.

Files with missing lines	Patch %	Lines
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt	28.33%	39 Missing and 4 partials ⚠️
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java	0.00%	10 Missing ⚠️
...i/jicofo/bridge/colibri/ColibriV2SessionManager.kt	0.00%	7 Missing ⚠️
...org/jitsi/jicofo/bridge/VisitorTopologyStrategy.kt	0.00%	3 Missing ⚠️
...in/kotlin/org/jitsi/jicofo/bridge/BridgeMetrics.kt	92.30%	1 Missing ⚠️
...n/kotlin/org/jitsi/jicofo/bridge/BridgeSelector.kt	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1210      +/-   ##
============================================
- Coverage     27.27%   26.64%   -0.64%     
+ Complexity      489      471      -18     
============================================
  Files           125      126       +1     
  Lines          8084     8208     +124     
  Branches       1121     1143      +22     
============================================
- Hits           2205     2187      -18     
- Misses         5597     5731     +134     
- Partials        282      290       +8     

Files with missing lines	Coverage Δ
...ain/kotlin/org/jitsi/jicofo/bridge/BridgeConfig.kt	93.69% <100.00%> (+2.51%)	⬆️
...tsi/jicofo/bridge/colibri/ColibriSessionManager.kt	0.00% <ø> (ø)
...in/kotlin/org/jitsi/jicofo/bridge/BridgeMetrics.kt	92.30% <92.30%> (ø)
...n/kotlin/org/jitsi/jicofo/bridge/BridgeSelector.kt	60.46% <50.00%> (-0.31%)	⬇️
...org/jitsi/jicofo/bridge/VisitorTopologyStrategy.kt	0.00% <0.00%> (ø)
...i/jicofo/bridge/colibri/ColibriV2SessionManager.kt	0.00% <0.00%> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java	40.39% <0.00%> (-2.16%)	⬇️
.../src/main/kotlin/org/jitsi/jicofo/bridge/Bridge.kt	59.45% <28.33%> (-13.44%)	⬇️

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54138e0...61e2dc1. Read the comment docs.

[JonathanLennox]

I'm confused by this BASE vs. the BASE defined below

[bgrozev]

I'm confused too. It didn't need to be imported, removed. Not sure why ktlint didn't catch it.

[bgrozev]

Looks like a ktlint bug, it fails to detect an unused import when it's from the same package. I can repro with ktlint 1.5 (with and without maven), but if I isolate it to a trivial case it works.

[bgrozev]

aha: pinterest/ktlint#2855