squash: Do not create multiple times the parser on hotter paths.

jitsi · Oct 31, 2024 · 19f9bca · 19f9bca
1 parent 54b5966
commit 19f9bca
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/main/java/org/jitsi/jigasi/AudioModeration.java b/src/main/java/org/jitsi/jigasi/AudioModeration.java
@@ -614,6 +614,8 @@ private IQ handleMuteIq(MuteIq muteIq)
     private class AVModerationListener
         implements StanzaListener
     {
+        private JSONParser parser = new JSONParser();
+
         @Override
         public void processStanza(Stanza packet)
         {
@@ -627,7 +629,7 @@ public void processStanza(Stanza packet)
 
             try
             {
-                Object o = new JSONParser().parse(jsonMsg.getJson());
+                Object o = parser.parse(jsonMsg.getJson());
 
                 if (o instanceof JSONObject)
                 {

diff --git a/src/main/java/org/jitsi/jigasi/transcription/VoskTranscriptionService.java b/src/main/java/org/jitsi/jigasi/transcription/VoskTranscriptionService.java
@@ -76,6 +76,8 @@ public class VoskTranscriptionService
      */
     private String websocketUrl;
 
+    private final JSONParser jsonParser = new JSONParser();
+
     /**
      * Assigns the websocketUrl to use to websocketUrl by reading websocketUrlConfig;
      */
@@ -281,7 +283,7 @@ private void onMessageInternal(String msg)
 
             boolean partial = true;
             String result = "";
-            JSONObject obj = (JSONObject)new JSONParser().parse(msg);
+            JSONObject obj = (JSONObject)jsonParser.parse(msg);
             if (obj.containsKey("partial"))
             {
                 result = (String)obj.get("partial");

diff --git a/src/main/java/org/jitsi/jigasi/transcription/WhisperWebsocket.java b/src/main/java/org/jitsi/jigasi/transcription/WhisperWebsocket.java
@@ -153,6 +153,8 @@ public class WhisperWebsocket
      */
     private static final ExecutorService threadPool = Util.createNewThreadPool("jigasi-whisper-ws");
 
+    private final JSONParser jsonParser = new JSONParser();
+
     /**
      * Creates a connection url by concatenating the websocket
      * url with the Connection Id;
@@ -318,7 +320,7 @@ private void onMessageInternal(String msg)
         boolean partial = true;
         String result;
 
-        JSONObject obj = (JSONObject)new JSONParser().parse(msg);
+        JSONObject obj = (JSONObject)jsonParser.parse(msg);
         String msgType = (String)obj.get("type");
         String participantId = (String)obj.get("participant_id");
         Participant participant = participants.get(participantId);

diff --git a/src/main/java/org/jitsi/jigasi/visitor/WebsocketClient.java b/src/main/java/org/jitsi/jigasi/visitor/WebsocketClient.java
@@ -123,6 +123,8 @@ public class WebsocketClient
      */
     private ScheduledFuture ponger;
 
+    private final JSONParser jsonParser = new JSONParser();
+
     /**
      * A timer which will be used to schedule connection to conference after going live.
      */
@@ -371,7 +373,7 @@ else if (command.equals("MESSAGE"))
         {
             try
             {
-                Object o = new JSONParser().parse(body.replace(END, ""));
+                Object o = jsonParser.parse(body.replace(END, ""));
 
                 if (o instanceof JSONObject)
                 {