fix: Make room_metadata Prosody module depend on the required jitsi_session module #14012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession module Without this room_metadata will silently discard all room metadata client requests assuming that they didn’t come from Jitsi meet clients. Fixes jitsi#14001
|
Hi, thanks for your contribution! |
|
CLA submitted (name Yuki Schlarb) – never had a system so blatantly demo how pointless “handwritten” signatures are in electronic communication 😮 😁 (If you don’t know what I mean, the CLA submission system actually offers to generate a convincing looking handwritten signature image based on the name you entered for you – it’s even the default option and get to pick a writing style too!) |
damencho
approved these changes
Nov 1, 2023
|
jenkins test this please. |
saghul
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this room_metadata will silently discard all room metadata client requests assuming that they didn’t come from Jitsi meet clients.
Fixes #14001
Detailed description in that issue.