Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findRtpSource for non-primary ssrc's. #2269

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Fix findRtpSource for non-primary ssrc's. #2269

merged 2 commits into from
Jan 7, 2025

Conversation

JonathanLennox
Copy link
Member

No description provided.

@JonathanLennox JonathanLennox merged commit db7d0b8 into jitsi:master Jan 7, 2025
4 checks passed
@savely-krasovsky
Copy link

savely-krasovsky commented Jan 21, 2025 •
edited
Loading

Could this fix relate to those errors we periodically see in our logs? We think this causes rare issue when sound from some participants turns off for some reason.

JVB 2025-01-15 11:15:32.232 SEVERE: [200] [confId=b35b2538906c7ca1 conf_name=68b24fc5-4a24-4f6e-a2a9-43328360694a@muc.meet.jitsi meeting_id=22b13e1b epId=28256d0d stats_id=Krystina-rqt] Endpoint.findAudioSourceProps#899: No properties found for SSRC 478973860.

@bgrozev
Copy link
Member

bgrozev commented Jan 22, 2025

Could this fix relate to those errors we periodically see in our logs? We think this causes rare issue when sound from some participants turns off for some reason.

JVB 2025-01-15 11:15:32.232 SEVERE: [200] [confId=b35b2538906c7ca1 conf_name=68b24fc5-4a24-4f6e-a2a9-43328360694a@muc.meet.jitsi meeting_id=22b13e1b epId=28256d0d stats_id=Krystina-rqt] Endpoint.findAudioSourceProps#899: No properties found for SSRC 478973860.

Unlikely. I think the message you see can happen when an endpoint has recently expired, or otherwise it's audio SSRC was removed (or hasn't been added yet). Does it appear a single time or repeatedly?

@savely-krasovsky
Copy link

savely-krasovsky commented Jan 22, 2025 •
edited
Loading

@bgrozev Repeteadly. I guess we can share an example of FINER log privately.

@savely-krasovsky savely-krasovsky mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrozev bgrozev bgrozev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonathanLennox @savely-krasovsky @bgrozev