From 74f48eaaa754a6d901b324393dd92035b718b6f8 Mon Sep 17 00:00:00 2001 From: jiyun Date: Wed, 22 May 2024 23:37:08 +0900 Subject: [PATCH] =?UTF-8?q?[Refactor]=20response=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/jiyunio/todolist/category/CategoryController.java | 7 +++---- .../java/com/jiyunio/todolist/member/MemberController.java | 7 +++---- .../java/com/jiyunio/todolist/todo/TodoController.java | 7 +++---- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/main/java/com/jiyunio/todolist/category/CategoryController.java b/src/main/java/com/jiyunio/todolist/category/CategoryController.java index 96a5770..1b8270f 100644 --- a/src/main/java/com/jiyunio/todolist/category/CategoryController.java +++ b/src/main/java/com/jiyunio/todolist/category/CategoryController.java @@ -1,7 +1,7 @@ package com.jiyunio.todolist.category; -import com.jiyunio.todolist.responseDTO.ResponseDTO; import com.jiyunio.todolist.responseDTO.ResponseCategoryDTO; +import com.jiyunio.todolist.responseDTO.ResponseDTO; import io.swagger.v3.oas.annotations.Operation; import io.swagger.v3.oas.annotations.Parameter; import io.swagger.v3.oas.annotations.tags.Tag; @@ -43,9 +43,8 @@ public ResponseEntity updateCategory(@Parameter(description @Operation(summary = "카테고리 삭제") public ResponseEntity deleteCategory(@Parameter(description = "카테고리의 id") @PathVariable Long categoryId) { categoryService.deleteCategory(categoryId); - ResponseDTO responseDTO = ResponseDTO.builder() + return ResponseEntity.ok(ResponseDTO.builder() .msg("카테고리 삭제 성공") - .build(); - return new ResponseEntity<>(responseDTO, HttpStatus.NO_CONTENT); + .build()); } } diff --git a/src/main/java/com/jiyunio/todolist/member/MemberController.java b/src/main/java/com/jiyunio/todolist/member/MemberController.java index 108466c..880a6de 100644 --- a/src/main/java/com/jiyunio/todolist/member/MemberController.java +++ b/src/main/java/com/jiyunio/todolist/member/MemberController.java @@ -1,9 +1,9 @@ package com.jiyunio.todolist.member; -import com.jiyunio.todolist.responseDTO.ResponseDTO; import com.jiyunio.todolist.member.dto.ChangeUserPwDTO; import com.jiyunio.todolist.member.dto.SignInDTO; import com.jiyunio.todolist.member.dto.SignUpDTO; +import com.jiyunio.todolist.responseDTO.ResponseDTO; import com.jiyunio.todolist.responseDTO.ResponseMemberDTO; import io.swagger.v3.oas.annotations.Operation; import io.swagger.v3.oas.annotations.Parameter; @@ -43,10 +43,9 @@ public ResponseEntity updateUserPw(@Parameter(description = " @Operation(summary = "회원 탈퇴", description = "비밀번호 이용") public ResponseEntity deleteMember(@Parameter(description = "member의 id") @PathVariable Long memberId, @RequestParam String userPw) { memberService.deleteMember(memberId, userPw); - ResponseDTO responseDTO = ResponseDTO.builder() + return ResponseEntity.ok(ResponseDTO.builder() .msg("회원 탈퇴 성공") - .build(); - return new ResponseEntity<>(responseDTO, HttpStatus.NO_CONTENT); + .build()); } } diff --git a/src/main/java/com/jiyunio/todolist/todo/TodoController.java b/src/main/java/com/jiyunio/todolist/todo/TodoController.java index f3b1b41..773e6c9 100644 --- a/src/main/java/com/jiyunio/todolist/todo/TodoController.java +++ b/src/main/java/com/jiyunio/todolist/todo/TodoController.java @@ -45,9 +45,8 @@ public ResponseEntity updateTodo(@Parameter(description = "todo의 id") @Path @Operation(summary = "todo 삭제") public ResponseEntity deleteTodo(@Parameter(description = "todo의 id") @PathVariable Long todoId) { todoService.deleteTodo(todoId); - ResponseDTO responseDTO = ResponseDTO.builder() - .msg("Todo 삭제 완료") - .build(); - return new ResponseEntity<>(responseDTO, HttpStatus.NO_CONTENT); + return ResponseEntity.ok(ResponseDTO.builder() + .msg("todo 삭제 성공") + .build()); } }