Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new file for animation and new function for animation #362

Closed
wants to merge 1 commit into from
Closed

added new file for animation and new function for animation #362

wants to merge 1 commit into from

Conversation

ArshErgon
Copy link
Contributor

for the issue: #315 I have added a new file for animation type enum
@jmakhack can you tell which type of animation should I add inside the enum?

@ghost
Copy link

ghost commented Oct 16, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@jmakhack
Copy link
Owner

@ArshErgon please make sure the new dropdown works with the existing animation settings already in the plugin. See #163 if you need a reference.

For the animation options, use the existing one and add any other for now. Please add unit testing as well.

@jmakhack jmakhack added this to the v2.0.0 milestone Nov 5, 2022
@jmakhack jmakhack closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants