Fimo, allow for dict[str, numpy.ndarray] as input for motif argument. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Jacob
The documentation of Fimo states that a dict[str, numpy.ndarray] can be used as input for the motif argument.
Internally pwm's were always converted from torch.Tensors to numpy.ndarray, resulting in an attribute error
when using dict[str, numpy.ndarray] as input.
This PR fixes this issue.
[EDIT]
Ok, I realised that the order of the motifs matter. I.e. reverse complement motifs should be at the end of the list of motifs (in the same order as the non-reverse-complemented ones). This extra commit should adres this: 1f46d74
Best,
Seppe De Winter