Merge pull request #103 from joernio/claudiu/fixid

Ensure uniqueness of query names across bundles

src/main/scala/io/joern/scanners/ghidra/DangerousFunctions.scala

@@ -12,7 +12,7 @@ object DangerousFunctions extends QueryBundle {
   @q
   def strcpyUsed(): Query =
     Query.make(
-      name = "call-to-strcpy",
+      name = "call-to-strcpy-ghidra",
       author = Crew.suchakra,
       title = "Dangerous functions `strcpy` or `strncpy` used",
       description =

src/test/scala/io/joern/suites/AllBundlesTestSuite.scala

@@ -0,0 +1,27 @@
+package io.joern.suites
+
+import io.shiftleft.console.QueryDatabase
+import io.shiftleft.semanticcpg.language._
+import org.scalatest.wordspec.AnyWordSpec
+import io.shiftleft.dataflowengineoss.queryengine.EngineContext
+import io.shiftleft.dataflowengineoss.semanticsloader.Semantics
+import org.scalatest.matchers.should.Matchers.convertToAnyShouldWrapper
+
+import org.scalatest.matchers.should.Matchers._
+
+
+class AllBundlesTestSuite extends AnyWordSpec {
+  val argumentProvider = new QDBArgumentProvider(3)
+
+  "Complete QueryDatabase" should {
+    "should contain queries with unique names" in {
+      val qdb = new QueryDatabase(argumentProvider)
+      val nonUniqueNames =
+        qdb.allQueries
+          .groupBy(_.name)
+          .filter{ q => q._2.size > 1 }
+          .map(_._1)
+      nonUniqueNames shouldBe List()
+    }
+  }
+}