diff --git a/src/main/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctions.scala b/src/main/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctions.scala index 13e67bd..44e3068 100644 --- a/src/main/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctions.scala +++ b/src/main/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctions.scala @@ -11,25 +11,6 @@ object UserInputIntoDangerousFunctions extends QueryBundle { implicit val resolver: ICallResolver = NoResolve - @q - def mainArgsToStrcpy()(implicit context: EngineContext): Query = - Query.make( - name = "main-args-to-strcpy", - author = Crew.claudiu, - title = "`main` fn arguments used in strcpy source buffer", - description = - """ - |User-input ends up in source buffer argument of strcpy, which might overflow the destination buffer. - |""".stripMargin, - score = 4, - withStrRep({ cpg => - def source = cpg.method.fullName("main").parameter - def sink = cpg.method.fullName("strcpy").parameter.index(2) - sink.reachableBy(source).l - }), - tags = List(QueryTags.badfn) - ) - @q def getenvToStrcpy()(implicit context: EngineContext): Query = Query.make( diff --git a/src/test/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctionsTests.scala b/src/test/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctionsTests.scala index 8e992dc..1a66473 100644 --- a/src/test/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctionsTests.scala +++ b/src/test/scala/io/joern/scanners/ghidra/UserInputIntoDangerousFunctionsTests.scala @@ -3,21 +3,9 @@ package io.joern.scanners.ghidra import io.joern.suites.GhidraQueryTestSuite import org.scalatest.Ignore -@Ignore class UserInputIntoDangerousFunctionsTests extends GhidraQueryTestSuite { override def queryBundle = UserInputIntoDangerousFunctions - "mainArgsToStrcpy query" when { - def query = queryBundle.mainArgsToStrcpy() - "executed on CPG for binary with dataflow between `main` fn args and `strcpy` source argument" should { - "find the `main` function among the tracking points returned" in { - buildCpgForBin("buf1.exe") - val results = methodNamesForMatchedPoints(query) - results shouldBe Set("main") - } - } - } - "getenvToStrcpy query" when { def query = queryBundle.getenvToStrcpy()