Skip to content

Commit adf8b41

Browse files
johman10rockbenben
andauthored
Fix build errors on Windows and upgrade dependencies in build.yml (#4)
Co-authored-by: rockbenben <qingwhat@gmail.com>
1 parent 57a97b6 commit adf8b41

File tree

3 files changed

+25
-5
lines changed

3 files changed

+25
-5
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ jobs:
1515

1616
strategy:
1717
matrix:
18-
node-version: [19.x]
18+
node-version: [20]
1919
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2020

2121
steps:
22-
- uses: actions/checkout@v2
22+
- uses: actions/checkout@v4
2323
- name: Use Node.js ${{ matrix.node-version }}
24-
uses: actions/setup-node@v1
24+
uses: actions/setup-node@v4
2525
with:
2626
node-version: ${{ matrix.node-version }}
2727
- run: npm ci

package-lock.json

Lines changed: 19 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"start:chrome": "TARGET_BROWSER=chrome webpack --config webpack/webpack.dev.js --watch",
99
"start:firefox": "TARGET_BROWSER=firefox webpack --config webpack/webpack.dev.js --watch",
1010
"build": "npm run build:chrome && npm run build:firefox",
11-
"build:chrome": "TARGET_BROWSER=chrome webpack --config webpack/webpack.prod.js",
12-
"build:firefox": "TARGET_BROWSER=firefox webpack --config webpack/webpack.prod.js",
11+
"build:chrome": "cross-env TARGET_BROWSER=chrome webpack --config webpack/webpack.prod.js",
12+
"build:firefox": "cross-env TARGET_BROWSER=firefox webpack --config webpack/webpack.prod.js",
1313
"clean": "rimraf dist",
1414
"test": "jest",
1515
"style": "prettier --write \"src/**/*.{ts,tsx}\"",
@@ -41,6 +41,7 @@
4141
"@typescript-eslint/eslint-plugin": "^7.7.1",
4242
"@typescript-eslint/parser": "^7.7.1",
4343
"copy-webpack-plugin": "^12.0.2",
44+
"cross-env": "^7.0.3",
4445
"eslint": "^8.50.0",
4546
"eslint-plugin-react": "^7.34.1",
4647
"jest": "^29.7.0",

0 commit comments

Comments
 (0)