fix: Support for providers without native tool calling

Author: johnbean393

Sidekick.xcodeproj/project.xcworkspace/xcuserdata/bj.xcuserdatad/UserInterfaceState.xcuserstate

@@ -50,6 +50,26 @@
         }
       }
     },
+    "A new endpoint has been selected, which has been identified as capable of native tool calling. Would you like to turn on native tool calling?" : {
+      "localizations" : {
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "已选择一个新的端点，该端点已被确认支持原生工具调用功能。您是否要启用原生工具调用？"
+          }
+        }
+      }
+    },
+    "A new endpoint has been selected, which might not be capable of native tool calling. Would you like to turn off native tool calling?" : {
+      "localizations" : {
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "已选择新端点，该端点可能不支持原生工具调用功能。是否要关闭原生工具调用？"
+          }
+        }
+      }
+    },
     "A new remote model has been selected, which has been identified as having vision capabilities. Would you like to turn on vision for this model?" : {
       "localizations" : {
         "zh-Hans" : {
@@ -670,6 +690,16 @@
         }
       }
     },
+    "Controls whether native tool calling is available for the remote model. Turn it on only when the inference provider supports native tool calling for the selected model." : {
+      "localizations" : {
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "控制远程模型是否支持原生工具调用功能。仅在推理服务提供商确认所选模型支持原生工具调用时，才开启此选项。"
+          }
+        }
+      }
+    },
     "Controls whether Sidekick launches automatically at login." : {
       "localizations" : {
         "zh-Hans" : {
@@ -2407,6 +2437,16 @@
         }
       }
     },
+    "Native Tool Calling" : {
+      "localizations" : {
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "原生工具调用"
+          }
+        }
+      }
+    },
     "Needed to access an API for inference" : {
       "localizations" : {
         "zh-Hans" : {
@@ -2827,6 +2867,16 @@
         }
       }
     },
+    "Provider Changed" : {
+      "localizations" : {
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "新端点"
+          }
+        }
+      }
+    },
     "Reasoning Process" : {
       "localizations" : {
         "zh-Hans" : {

Sidekick/Localizable.xcstrings

@@ -93,8 +93,8 @@ struct ChatParameters: Codable {
     ) -> String {
         // Declare variable for params
         var params: any Codable = self
-        // If modelType is .worker, encode without tools
-        if modelType == .worker {
+        // If modelType is .worker, or if native tools disabled in settings, encode without tools
+        if modelType == .worker || !InferenceSettings.hasNativeToolCalling {
             // Omit 'tools'
             struct EncodableWithoutTools: Codable {
                 let model: String

Sidekick/Logic/Inference/llama.cpp/Types/ChatParameters.swift

@@ -253,7 +253,7 @@ Current date & time: \(Date.now.formatted(date: .long, time: .shortened))
 	}
 
     /// A `Bool` representing whether the LLM has vision
-    static var serverModelHasVision: Bool {
+    public static var serverModelHasVision: Bool {
         get {
             // Set default
             if !UserDefaults.standard.exists(key: "serverModelHasVision") {
@@ -268,7 +268,37 @@ Current date & time: \(Date.now.formatted(date: .long, time: .shortened))
             UserDefaults.standard.set(newValue, forKey: "serverModelHasVision")
         }
     }
+    
+    /// A `Bool` representing whether the inference provider supports tool calling natively
+    public static var hasNativeToolCalling: Bool {
+        get {
+            // Set default
+            if !UserDefaults.standard.exists(key: "hasNativeToolCalling") {
+                // Use default
+                Self.hasNativeToolCalling = Self.providerSupportsToolCalling() ?? false
+            }
+            return UserDefaults.standard.bool(
+                forKey: "hasNativeToolCalling"
+            )
+        }
+        set {
+            UserDefaults.standard.set(newValue, forKey: "hasNativeToolCalling")
+        }
+    }
 
+    /// A function to check if the provider selected supports tool calling
+    public static func providerSupportsToolCalling() -> Bool? {
+        // Check inference provider
+        for provider in Provider.popularProviders {
+            // If matches, use provider value
+            if Self.endpoint == provider.endpointUrl.absoluteString {
+                return provider.supportsToolCalling
+            }
+        }
+        // Default to nil
+        return nil
+    }
+    
 	/// A `String` representing the name of the remote worker model
 	public static var serverWorkerModelName: String {
 		get {

Sidekick/Logic/Settings/InferenceSettings.swift

@@ -16,16 +16,20 @@ public struct Provider: Identifiable {
     public var name: String
     /// A `URL` for the provider's OpenAI compatible endpoint
     public var endpointUrl: URL
+    /// A `Bool` for whether the provider supports OpenAI style tool calling
+    public var supportsToolCalling: Bool = false
 
     /// A list of popular providers
     public static let popularProviders: [Provider] = [
         Provider(
             name: "Aliyun Bailian (China)",
-            endpointUrl: URL(string: "https://dashscope.aliyuncs.com/compatible-mode/v1")!
+            endpointUrl: URL(string: "https://dashscope.aliyuncs.com/compatible-mode/v1")!,
+            supportsToolCalling: true
         ),
         Provider(
             name: "Anthropic",
-            endpointUrl: URL(string: "https://api.anthropic.com/v1")!
+            endpointUrl: URL(string: "https://api.anthropic.com/v1")!,
+            supportsToolCalling: true
         ),
         Provider(
             name: "DeepSeek",
@@ -37,27 +41,32 @@ public struct Provider: Identifiable {
         ),
         Provider(
             name: "Groq",
-            endpointUrl: URL(string: "https://api.groq.com/openai/v1")!
+            endpointUrl: URL(string: "https://api.groq.com/openai/v1")!,
+            supportsToolCalling: true
         ),
         Provider(
             name: "LM Studio",
-            endpointUrl: URL(string: "http://localhost:1234/v1")!
+            endpointUrl: URL(string: "http://localhost:1234/v1")!,
+            supportsToolCalling: true
         ),
         Provider(
             name: "Mistral",
             endpointUrl: URL(string: "https://api.mistral.ai/v1")!
         ),
         Provider(
             name: "Ollama",
-            endpointUrl: URL(string: "http://localhost:11434/v1")!
+            endpointUrl: URL(string: "http://localhost:11434/v1")!,
+            supportsToolCalling: true
         ),
         Provider(
             name: "OpenAI",
-            endpointUrl: URL(string: "https://api.openai.com/v1")!
+            endpointUrl: URL(string: "https://api.openai.com/v1")!,
+            supportsToolCalling: true
         ),
         Provider(
             name: "OpenRouter",
-            endpointUrl: URL(string: "https://openrouter.ai/api/v1")!
+            endpointUrl: URL(string: "https://openrouter.ai/api/v1")!,
+            supportsToolCalling: true
         )
     ]
 }

Sidekick/Types/Model/Provider.swift

@@ -15,7 +15,10 @@ struct ServerModelSettingsView: View {
 	@State private var inferenceApiKey: String = InferenceSettings.inferenceApiKey
 
 	@AppStorage("remoteModelName") private var serverModelName: String = InferenceSettings.serverModelName
+    
     @AppStorage("serverModelHasVision") private var serverModelHasVision: Bool = InferenceSettings.serverModelHasVision
+    @AppStorage("hasNativeToolCalling") private var hasNativeToolCalling: Bool = InferenceSettings.hasNativeToolCalling
+    
 	@AppStorage("serverWorkerModelName") private var serverWorkerModelName: String = ""
 
     var popularEndpointsTip: PopularEndpointsTip = .init()
@@ -40,6 +43,7 @@ struct ServerModelSettingsView: View {
 					modelType: .regular
 				)
                 serverModelHasVisionToggle
+                hasNativeToolCallingToggle
 				ServerModelNameEditor(
 					serverModelName: $serverWorkerModelName,
 					modelType: .worker
@@ -126,6 +130,14 @@ struct ServerModelSettingsView: View {
 			}
             .padding(.top, 10)
 		}
+        .onChange(of: self.serverEndpoint) {
+            // Return if invalid or blank
+            if !self.endpointUrlIsValid || self.serverEndpoint.isEmpty {
+                return
+            }
+            // Else, run check
+            self.checkProviderForToolCalling()
+        }
 	}
 
 	var inferenceApiKeyEditor: some View {
@@ -166,4 +178,46 @@ struct ServerModelSettingsView: View {
         }
     }
 
+    var hasNativeToolCallingToggle: some View {
+        HStack(alignment: .top) {
+            VStack(alignment: .leading) {
+                Text("Native Tool Calling")
+                    .font(.title3)
+                    .bold()
+                Text("Controls whether native tool calling is available for the remote model. Turn it on only when the inference provider supports native tool calling for the selected model.")
+                    .font(.caption)
+            }
+            Spacer()
+            Toggle(
+                "",
+                isOn: $hasNativeToolCalling.animation(.linear)
+            )
+            .disabled(serverEndpoint.isEmpty || !endpointUrlIsValid)
+        }
+    }
+    
+    private func checkProviderForToolCalling() {
+        // Check provider, defaulting to false
+        let providerSupportsToolCalling = InferenceSettings.providerSupportsToolCalling() ?? false
+        // If no change, exit
+        if providerSupportsToolCalling == self.hasNativeToolCalling {
+            return
+        }
+        // Get message
+        let message: String = providerSupportsToolCalling ? String(localized: "A new endpoint has been selected, which has been identified as capable of native tool calling. Would you like to turn on native tool calling?") : String(
+            localized: "A new endpoint has been selected, which might not be capable of native tool calling. Would you like to turn off native tool calling?"
+        )
+        // Confirm with user
+        if Dialogs.dichotomy(
+            title: String(localized: "Provider Changed"),
+            message: message,
+            option1: String(localized: "Yes"),
+            option2: String(localized: "No")
+        ) {
+            withAnimation(.linear) {
+                self.hasNativeToolCalling = providerSupportsToolCalling
+            }
+        }
+    }
+    
 }