Fix typing for uuid4() #2164
Closed
Fix typing for uuid4() #2164
+195
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thank you!
We must also update the generate_stubs.py script to support the @overload decorator.
|
@fcurella done. Also updated the dependency management to make it easier to consistently develop |
evenicoulddoit
commented
Feb 7, 2025
| @@ -8,13 +8,16 @@ mypy: | |||
| mypy --install-types --non-interactive --config mypy.ini faker | |||
|
|
|||
| black: | |||
| black --line-length 120 . | |||
There was a problem hiding this comment.
This is now defined in pyproject.toml and needn't be tracked elsewhere.
evenicoulddoit
commented
Feb 7, 2025
Comment on lines
+18
to
+19
| black faker/proxy.pyi | ||
| isort faker/proxy.pyi |
There was a problem hiding this comment.
Unless these are applied you don't actually see your changes properly.
3 tasks
|
Done in 9c8b132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
uuid4(), so that static type checkers understand the return type based on the inputsWhat was wrong
uuid4(), because these tools rightly point out that the return type is one ofUUID | str | bytesHow this fixes it
Checklist
make lint