cleanup code for database restore dialog. Remove some javascript warns on IDE

Author: jonsito

agility/scripts/admin.js.php

@@ -250,19 +250,21 @@ function restoreDatabase(fromClient){
     var l2='<?php _e("This operation <strong>WILL ERASE <em>EVERY</em> CURRENT DATA</strong>. before trying restore<br/>"); ?>';
     var l3='<?php _e("Be aware of making a backup copy before continue<br/><br/>"); ?>';
     var l4='<?php _e("To continue enter administrator password and press <em>Accept</em>"); ?>';
-    var title='<?php _e('DataBase restore'); ?>';
+    var titl='<?php _e('DataBase restore'); ?>';
     if (fromClient) {
         // use file selected from user
-        if ($('#tools-restoreFile').val()=="") {
+        if ($('#tools-restoreFile').val()==="") {
             $.messager.alert("Restore",'<?php _e("You should specify an <em>.sql</em> file with a previous backup"); ?>',"error");
             return false;
         }
     } else {
-        title='<?php _e('DataBase update'); ?>';
+        titl='<?php _e('DataBase update'); ?>';
     }
-    $.messager.password(title,l1+l2+l3+l4 , function(pass){
-        if (pass){
-            // comprobamos si el password es correcto
+    $.messager.password(
+        titl,
+        l1+l2+l3+l4,
+        function(pass){
+            if (!pass) return false;// comprobamos si el password es correcto
             checkPassword(ac_authInfo.Login,pass,function(data) {
                 if (data.errorMsg) {
                     // error  en comprobación de password
@@ -346,9 +348,10 @@ function getProgress(){
                     });
 
                     if (fromClient) {
+                        let tupl=$('#tools-uploader');
                         // upload local database file
                         // incicializamos el uploader
-                        $('#tools-uploader').fileUploader( {
+                        tupl.fileUploader( {
                             selector: '#tools-restoreFile', // ID of "file" input field
                             button: null, // ID of submit button
                             progress: setProgressValue, // ID or function to send upload progress info to
@@ -367,7 +370,7 @@ function getProgress(){
                         });
 
                         // arrancamos el proceso de restore
-                        $('#tools-uploader').fileUploader('upload');
+                        tupl.fileUploader('upload');
                     } else {
                         // download database from master server
                         doRestore();
@@ -377,7 +380,7 @@ function getProgress(){
                 }
             });
         }
-    }).window('resize',{width:640});
+    ).window('resize',{width:450});
 }
 
 function clearDatabase(){

agility/scripts/common.js.php

@@ -499,7 +499,7 @@ function loadConfiguration(callback) {
                 $('#mylogo_release').html(ac_config.version_date);
 
 				// extra configuration data to speedup
-				ac_config.numdecs=(ac_config.crono_milliseconds=="0")?2:3;
+				ac_config.numdecs=(parseInt(ac_config.crono_milliseconds)===0)?2:3;
 				ac_config.dogInRing=false; // to be used in videowall and livestream to show dog info and timings
 
                 // auto-backup related variables

agility/scripts/easyui-patches.js

@@ -259,9 +259,9 @@ $.extend($.fn.datagrid.methods, {
 		return win;
 	};
     $.messager.password =function(title,msg,fn){
-        var content="<div class=\"messager-icon messager-warning\"></div>"+
-            "<div>"+msg+"</div>"+"<br />"+"<div style=\"clear:both;\"/>"+
-            "<div><input class=\"messager-input\" type=\"password\"/></div>";
+        var content='<div class="messager-icon messager-warning"></div>'+
+            '<div>'+msg+'</div><br /><div style="clear:both;"/>'+
+            '<div><input class="messager-input" type="password" style="width:50%"/></div>';
         var buttons={};
         buttons[$.messager.defaults.ok]=function(){
             win.window('close');
@@ -273,14 +273,15 @@ $.extend($.fn.datagrid.methods, {
             return false;
         };
         var win=createDialog(title,content,buttons);
+        // seems that onchange is also fired when focus lost, so comment it
         // when enter is pressed in input box, assume "Accept" button
-        $(".messager-input",win).change(
-            function(){
-                win.window('close');
-                if (fn) { fn($(".messager-input",win).val()); }
-                return false;
-            }
-        );
+        // $(".messager-input",win).change(
+        //    function(){
+        //        win.window('close');
+        //        if (fn) { fn($(".messager-input",win).val()); }
+        //        return false;
+        //    }
+        // );
         win.find("input.messager-input").focus();
         return win;
     }