Merge pull request #3588 from JohannesBeranek/fix-#3586

jknack · web-flow · commit 84735ccbd932 · 2024-11-21T06:46:44.000-05:00
#3586 Fix RequestSessionFactory.StatefulSessionFactory create returning null session
diff --git a/modules/jooby-hibernate/src/main/java/io/jooby/internal/hibernate/RequestSessionFactory.java b/modules/jooby-hibernate/src/main/java/io/jooby/internal/hibernate/RequestSessionFactory.java
@@ -39,7 +39,8 @@ public StatefulSessionFactory(ServiceKey<SessionProvider> sessionProviderKey) {
     public SharedSessionContract create(Context ctx, SessionFactory sessionFactory) {
       var sessionProvider = ctx.require(sessionProviderKey);
       var session = sessionProvider.newSession(sessionFactory.withOptions());
-      return ManagedSessionContext.bind(session);
+      ManagedSessionContext.bind(session);
+      return session;
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ public StatefulSessionFactory(ServiceKey<SessionProvider> sessionProviderKey) {`
`39`	`39`	`public SharedSessionContract create(Context ctx, SessionFactory sessionFactory) {`
`40`	`40`	`var sessionProvider = ctx.require(sessionProviderKey);`
`41`	`41`	`var session = sessionProvider.newSession(sessionFactory.withOptions());`
`42`		`- return ManagedSessionContext.bind(session);`
	`42`	`+ ManagedSessionContext.bind(session);`
	`43`	`+ return session;`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`@Override`