Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Moya 적용 및 API 작성 #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Moya 적용 및 API 작성 #44

wants to merge 2 commits into from

Conversation

sunghong32
Copy link
Collaborator

[Feature]
close #40

  • Moya 적용
  • NetworkAPI 작성

@sunghong32 sunghong32 added the Feature 새 기능 및 구성 추가 label Aug 1, 2023
@sunghong32 sunghong32 requested a review from joseph704 August 1, 2023 08:13
@sunghong32 sunghong32 self-assigned this Aug 1, 2023
joseph704
joseph704 requested changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@joseph704 joseph704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunghong32
지금 APIKey.plist 노출되는데, gitignore에 해당 파일 추가해서 안보이도록 하고 로컬에서 나한테 전달해야할것 같아!

@joseph704
Copy link
Owner

@sunghong32
그리고 combineMoya 통해 Repository와 NetworkAPI 연결시켜주는 NetworkMagnger 클래스(provider 포함한) 작성 부탁할게
작성하고 테스트 코드도.. 쿠다사이

@sunghong32
Copy link
Collaborator Author

sunghong32 commented Aug 8, 2023 •
edited
Loading

그리고 combineMoya 통해 Repository와 NetworkAPI 연결시켜주는 NetworkMagnger 클래스(provider 포함한) 작성 부탁할게
@joseph704
이건 따로 이슈로 남겨놨어

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph704 joseph704 joseph704 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@sunghong32 sunghong32

Labels
Feature 새 기능 및 구성 추가
Projects
FifaOnline4 Info App
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moya 적용
2 participants
@sunghong32 @joseph704