Merge pull request #26 from rcgeorge23/ISSUE-25-split-on-first-equals

ISSUE-25: Splits env variable string on first occurrence of equals character

.gitignore

@@ -1,3 +1,4 @@
+.idea
 .DS_Store
 .vscode
 .settings
@@ -7,4 +8,4 @@
 coverage.out
 _archive
 dist/
-target/
+target/

Dockerfile

@@ -2,7 +2,7 @@
 ## Build kubedock ## ----------------------------------------------------------
 ####################
 
-FROM docker.io/golang:1.17 AS kubedock
+FROM docker.io/golang:1.18 AS kubedock
 
 ARG CODE=github.com/joyrex2001/kubedock
 

internal/model/types/container.go

@@ -70,12 +70,12 @@ const (
 func (co *Container) GetEnvVar() []corev1.EnvVar {
 	env := []corev1.EnvVar{}
 	for _, e := range co.Env {
-		f := strings.Split(e, "=")
-		if len(f) != 2 {
+		key, value, found := strings.Cut(e, "=")
+		if !found {
 			klog.Errorf("could not parse env %s", e)
 			continue
 		}
-		env = append(env, corev1.EnvVar{Name: f[0], Value: f[1]})
+		env = append(env, corev1.EnvVar{Name: key, Value: value})
 	}
 	return env
 }

internal/model/types/container_test.go

@@ -32,6 +32,20 @@ func TestGetEnvVar(t *testing.T) {
 				{Name: "rc768", Value: "Space Manbow"},
 			},
 		},
+		{
+			in: &Container{Env: []string{
+				"NO_EQUALS=123",
+				"EQUALS_AT_END=456=",
+				"EQUALS_IN_MIDDLE=abc123=aabbcc",
+				"MULTIPLE_EQUALS=abc123==aa=bb=cc==",
+			}},
+			out: []corev1.EnvVar{
+				{Name: "NO_EQUALS", Value: "123"},
+				{Name: "EQUALS_AT_END", Value: "456="},
+				{Name: "EQUALS_IN_MIDDLE", Value: "abc123=aabbcc"},
+				{Name: "MULTIPLE_EQUALS", Value: "abc123==aa=bb=cc=="},
+			},
+		},
 	}
 	for i, tst := range tests {
 		res := tst.in.GetEnvVar()