Merge pull request #248 from jparkerweb/develop

v3.5.4

Author: jparkerweb

CHANGELOG.md

@@ -3,6 +3,11 @@
 All notable changes to the Pixel Banner plugin will be documented in this file.
 
 ## 🎉 What's New
+### v3.5.4 - 2025-05-27
+#### 🐛 Fixed
+- Resolve issue with not evaluating all defined custom field names for "banner" frontmatter
+- Revert aggresive css change impacting the background color of some theme variations and plugins
+
 ### v3.5.3 - 2025-05-23
 #### ✨ Added
 - New `Icon Image Size Multiplier` control:

UPDATE.md

@@ -3,6 +3,11 @@
 </a>
 
 ## 🎉 What's New
+### v3.5.4 - 2025-05-27
+#### 🐛 Fixed
+- Resolve issue with not evaluating all defined custom field names for "banner" frontmatter
+- Revert aggresive css change impacting the background color of some theme variations and plugins
+
 ### v3.5.3 - 2025-05-23
 #### ✨ Added
 - New `Icon Image Size Multiplier` control:

manifest.json

@@ -1,7 +1,7 @@
 {
     "id": "pexels-banner",
     "name": "Pixel Banner",
-    "version": "3.5.3",
+    "version": "3.5.4",
     "minAppVersion": "1.6.0",
     "description": "Enhance your notes with customizable banner images, including AI-generated designs and a curated store of downloadable banners. Transform your workspace with visually stunning headers that add context, improve aesthetics, and take your note-taking beyond the ordinary.",
     "author": "Justin Parker (eQui\\\\ Labs)",

src/core/bannerUtils.js

@@ -222,7 +222,12 @@ function getActiveApiProvider() {
 
 function hasBannerFrontmatter(file) {
     const metadata = this.app.metadataCache.getFileCache(file);
-    return metadata?.frontmatter?.banner !== undefined;
+    if (!metadata?.frontmatter) return false;
+    
+    // Check all possible banner field names from settings
+    return this.settings.customBannerField.some(fieldName => 
+        metadata.frontmatter[fieldName] !== undefined
+    );
 }
 
 

src/modal/modals/selectPixelBannerModal.js

@@ -127,7 +127,10 @@ export class SelectPixelBannerModal extends Modal {
         const activeFile = this.app.workspace.getActiveFile();
         const hasBanner = activeFile ? (
             this.plugin.hasBannerFrontmatter(activeFile) || 
-            this.plugin.app.metadataCache.getFileCache(activeFile)?.frontmatter?.[this.plugin.settings.customBannerShuffleField[0]]
+            (this.plugin.app.metadataCache.getFileCache(activeFile)?.frontmatter && 
+             this.plugin.settings.customBannerShuffleField.some(field => 
+                this.plugin.app.metadataCache.getFileCache(activeFile)?.frontmatter?.[field]
+             ))
         ) : false;
 
         // Create main container

styles.css

@@ -65,11 +65,6 @@
     /* add transition to banner image background position */
     transition: background-position 0.5s ease;
 }
-/* fix background color preventing banner from showing in reading mode for some themes */
-.markdown-reading-view,
-[class^=markdown-preview] {
-    background-color: transparent !important;
-}
 
 .markdown-embed-content .markdown-preview-view {
     min-height: var(--pixel-banner-embed-min-height, unset) !important;