Enforce line and column indices for all language modules #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
enhancement
…cing line and column indices.
JanWittler
approved these changes
Aug 19, 2022
# Conflicts: # jplag/src/main/java/de/jplag/reporting/reportobject/mapper/ComparisonReportMapper.java
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the possibility to use the singular index in frontends, thus enforcing line and column indices for all language modules. Currently, all language modules support this, and new ones will be required to do so. For more information see this comment. Detailed changes:
Language#supportsColumns()(as we now assume this is always true)Token.getIndex()as this is now no longer neededComparisonReportMapperaccordingly