New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI behavior for enabling/disabling clustering calculation #611

Merged

tsaglam merged 9 commits into master from cli-cluster-fix

Aug 24, 2022

Member

tsaglam commented Aug 23, 2022 •

edited

Loading

Relates to #609:

Fixes a bug in the Clustering CLI: When --cluster-skip is not present enabled is set to false and clustering is skipped.
Adds test cases for expected behavior
Log if clustering is run, with which parameters and how many clusters are found
Log for each cluster the inter-cluster strength, the average similarity and the members
Fixes encapsulation of the cluster members

tsaglam added 4 commits

August 23, 2022 16:26


          Fix CLI bug that led to flipped behavior of --skip-clustering.

8c0aee0


          Add CLI cluster test cases for --skip-clustering.

f6d70ab


          Print clustering information when the cluster factory is called.

7526b8e


          Log information information regarding clustering results.

a188aff

tsaglam added bug minor labels

tsaglam added this to the v4.0.0 milestone

tsaglam added 5 commits

August 23, 2022 16:49


          Log all found clusters with their members and community strength.

8bd7224


          Log clusters sorted by their community strength.

3d1622c


          Minor improvements in cluster logging via a custom comparator.

7ace91a


          Avoid exposing of cluster members via accessors.

ec388dd


          Include average similarity into logged cluster information.

b5fc851

sonarqubecloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

88.9% Coverage
0.0% Duplication

tsaglam marked this pull request as ready for review

August 24, 2022 08:27

tsaglam merged commit 020f164 into master

tsaglam deleted the cli-cluster-fix branch

August 24, 2022 10:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug minor