Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add machine rename command #57

Closed
wants to merge 1 commit into from

Conversation

varchaar
Copy link

Fixes #56

Add a new command "rename" that take a --machine-id and a --new-name.

Sorry if something is amiss, it is my first time in Go.

Do I need to add tests ?
Also I restricted the action to tailnets admins, maybe find a way to allows owners of the machine ?

Signed-off-by: varchar <v.richard@protonmail.com>
@varchaar varchaar force-pushed the feature/rename-machine branch from c91f56c to c0d2536 Compare August 28, 2024 10:22
@jsiebens
Copy link
Owner

Hi @varchaar

Thanks for the PR, but I'll close this one in favour of #66, which covers some edge cases like switching back to the original os hostname, etc

@jsiebens jsiebens closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to rename machines/devices
2 participants