Skip to content

Custom filters in own project (unit tests) #1736

Open
@klavspc

Description

@klavspc

@bkoelman :
Thank you for your work with #1286 which will enable us to implement custom filters in our project. One such filter being filter=IsWithinBBox(geometry, Xmin, Xmax, Ymin, Ymax)

What is your suggestion on how we unit test our custom filters? I really like the simple and clear test you have here; Set up a reader and call .Read(parameterName, parameterValue).

I tried to replicate the test in our project, but unfortunately for us your tests depend on internal classes e.g. ResourceFactory. It'd be really nice if we could have unit tests as clean as yours. Does it make sense to you to expose the needed internals for this purpose?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions