ensure we do not parse email strings permissively

karenetheridge · karenetheridge · commit a1e077d4575e · 2025-06-06T19:38:53.000-07:00
e.g. we do not accept the entire "From" line from an email, nor two
comma-separated email addresses
diff --git a/tests/draft-next/optional/format/email.json b/tests/draft-next/optional/format/email.json
@@ -115,6 +115,16 @@
                 "description": "an invalid IPv4-address-literal",
                 "data": "joe.bloggs@[127.0.0.300]",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft2019-09/optional/format/email.json b/tests/draft2019-09/optional/format/email.json
@@ -80,6 +80,16 @@
                 "description": "two subsequent dots inside local part are not valid",
                 "data": "te..st@example.com",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft2020-12/optional/format/email.json b/tests/draft2020-12/optional/format/email.json
@@ -115,6 +115,16 @@
                 "description": "an invalid IPv4-address-literal",
                 "data": "joe.bloggs@[127.0.0.300]",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft3/optional/format/email.json b/tests/draft3/optional/format/email.json
@@ -47,6 +47,16 @@
                 "description": "two subsequent dots inside local part are not valid",
                 "data": "te..st@example.com",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft4/optional/format/email.json b/tests/draft4/optional/format/email.json
@@ -77,6 +77,16 @@
                 "description": "two subsequent dots inside local part are not valid",
                 "data": "te..st@example.com",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft6/optional/format/email.json b/tests/draft6/optional/format/email.json
@@ -77,6 +77,16 @@
                 "description": "two subsequent dots inside local part are not valid",
                 "data": "te..st@example.com",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }
diff --git a/tests/draft7/optional/format/email.json b/tests/draft7/optional/format/email.json
@@ -77,6 +77,16 @@
                 "description": "two subsequent dots inside local part are not valid",
                 "data": "te..st@example.com",
                 "valid": false
+            },
+            {
+                "description": "two email addresses is not valid",
+                "data": "user1@oceania.org, user2@oceania.org",
+                "valid": false
+            },
+            {
+                "description": "full \"From\" header is invalid",
+                "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",
+                "valid": false
             }
         ]
     }

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,16 @@`
`115`	`115`	`"description": "an invalid IPv4-address-literal",`
`116`	`116`	`"data": "joe.bloggs@[127.0.0.300]",`
`117`	`117`	`"valid": false`
	`118`	`+ },`
	`119`	`+ {`
	`120`	`+ "description": "two email addresses is not valid",`
	`121`	`+ "data": "user1@oceania.org, user2@oceania.org",`
	`122`	`+ "valid": false`
	`123`	`+ },`
	`124`	`+ {`
	`125`	`+ "description": "full \"From\" header is invalid",`
	`126`	`+ "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",`
	`127`	`+ "valid": false`
`118`	`128`	`}`
`119`	`129`	`]`
`120`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,16 @@`
`80`	`80`	`"description": "two subsequent dots inside local part are not valid",`
`81`	`81`	`"data": "te..st@example.com",`
`82`	`82`	`"valid": false`
	`83`	`+ },`
	`84`	`+ {`
	`85`	`+ "description": "two email addresses is not valid",`
	`86`	`+ "data": "user1@oceania.org, user2@oceania.org",`
	`87`	`+ "valid": false`
	`88`	`+ },`
	`89`	`+ {`
	`90`	`+ "description": "full \"From\" header is invalid",`
	`91`	`+ "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",`
	`92`	`+ "valid": false`
`83`	`93`	`}`
`84`	`94`	`]`
`85`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,16 @@`
`47`	`47`	`"description": "two subsequent dots inside local part are not valid",`
`48`	`48`	`"data": "te..st@example.com",`
`49`	`49`	`"valid": false`
	`50`	`+ },`
	`51`	`+ {`
	`52`	`+ "description": "two email addresses is not valid",`
	`53`	`+ "data": "user1@oceania.org, user2@oceania.org",`
	`54`	`+ "valid": false`
	`55`	`+ },`
	`56`	`+ {`
	`57`	`+ "description": "full \"From\" header is invalid",`
	`58`	`+ "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",`
	`59`	`+ "valid": false`
`50`	`60`	`}`
`51`	`61`	`]`
`52`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,16 @@`
`77`	`77`	`"description": "two subsequent dots inside local part are not valid",`
`78`	`78`	`"data": "te..st@example.com",`
`79`	`79`	`"valid": false`
	`80`	`+ },`
	`81`	`+ {`
	`82`	`+ "description": "two email addresses is not valid",`
	`83`	`+ "data": "user1@oceania.org, user2@oceania.org",`
	`84`	`+ "valid": false`
	`85`	`+ },`
	`86`	`+ {`
	`87`	`+ "description": "full \"From\" header is invalid",`
	`88`	`+ "data": "\"Winston Smith\" <winston.smith@recdep.minitrue> (Records Department)",`
	`89`	`+ "valid": false`
`80`	`90`	`}`
`81`	`91`	`]`
`82`	`92`	`}`