Skip to content

chore(github-actions) : Fixes notify-failed-actions workflow #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

aialok
Copy link
Member

@aialok aialok commented Jul 15, 2024

Closes: #737

Summary:

  • When any workflow fails, this workflow will notify about the failed workflow on GitHub Actions.

Notes:

  • There might be a need to change the Slack webhook URL because this workflow should notify only on the Slack GitHub channel.
  • Also, this workflow is using secrets for the webhook URL, while other workflows need to be updated to use secrets instead of vars.

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No
[No justification required as the change does not appear to be architecturally significant.]

@aialok aialok added the gsoc Google Summer of Code Project Idea label Jul 15, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookas good. Thanks Alok

@benjagm benjagm merged commit 523d586 into json-schema-org:main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Google Summer of Code Project Idea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: failed-actions-notify.yml is not working as expected
2 participants