Fix broken link titles when illegal characters present

Author: jsonMartin

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.0.2 (2021-05-24)
+### Fixed
+- Fixed linking bug when illegal characters were stripped in filename, but not in Note title (https://github.com/jsonMartin/readwise-mirror/issues/4)
+### Changed
+- Starting default sort order preference now sorts highlights chronologically from oldest to newest
+
 ## 1.0.1 (2021-05-24)
 ### Added
 - Added new checkbox in settings to allow highlights to be listed in reverse chronological order

main.ts

@@ -17,7 +17,7 @@ const DEFAULT_SETTINGS: PluginSettings = {
   apiToken: null,
   lastUpdated: null,
   autoSync: true,
-  highlightSortOldestToNewest: false,
+  highlightSortOldestToNewest: true,
 };
 
 export default class ReadwiseMirror extends Plugin {
@@ -75,7 +75,7 @@ ${text} ${book.category === 'books' ? locationBlock : ''}${color ? ` %% Color: $
         last_highlight_at,
         source_url,
       } = book;
-      const fileName = `${title.replace(/[<>:"\/\\|?*]+/g, '')}.md`;
+      const sanitizedTitle = `${title.replace(':', '-').replace(/[<>"'\/\\|?*]+/g, '')}`;
 
       const formattedHighlights = (this.settings.highlightSortOldestToNewest ? highlights.reverse() : highlights)
         .map((highlight: Highlight) => this.formatHighlight(highlight, book))
@@ -101,15 +101,18 @@ Updated: ${this.formatDate(updated)}
 ![](${cover_image_url.replace('SL200', 'SL500').replace('SY160', 'SY500')})
 
 # About
-Title: [[${title}]]
+Title: [[${sanitizedTitle}]]
 ${authors.length > 1 ? 'Authors' : 'Author'}: ${authorStr}
 Category: #${category}
 Number of Highlights: ==${num_highlights}==
 Last Highlighted: *${last_highlight_at ? this.formatDate(last_highlight_at) : 'Never'}*
 Readwise URL: ${highlights_url}${category === 'articles' ? `\nSource URL: ${source_url}\n` : ''}
 
 # Highlights ${formattedHighlights}`;
-      let path = `${this.settings.baseFolderName}/${category.charAt(0).toUpperCase() + category.slice(1)}/${fileName}`;
+
+      let path = `${this.settings.baseFolderName}/${
+        category.charAt(0).toUpperCase() + category.slice(1)
+      }/${sanitizedTitle}.md`;
 
       const abstractFile = vault.getAbstractFileByPath(path);
 

manifest.json

@@ -1,7 +1,7 @@
 {
   "id": "readwise-mirror",
   "name": "Readwise Mirror",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "minAppVersion": "0.11.0",
   "description": "Mirror your Readwise library directly to an Obsidian vault",
   "author": "jsonmartin",