feat: redo how we transpile JSR packages for NPM #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
redo_npm_packaging
branch
from
3afed11 to
d498e8c
Compare
This fixes various bugs, and introduces some features. Specifically: - Source code is now included in the bundle to enable better "Go to source definition" - More usecases using `/// <reference types="..." />` work correctly now, especially when d.ts file is not a sibling of the JS file. - We strip `/// <reference types="..." />` out of JS files correctly now. - We transpile `npm:` and `jsr:` specifiers in user provided `.d.ts` files now.
lucacasonato
force-pushed
the
redo_npm_packaging
branch
from
d498e8c to
ce16f86
Compare
lucacasonato
commented
Apr 15, 2024
.env.example
Outdated
There was a problem hiding this comment.
This was duplicated with the /api/.env.example.
ry
reviewed
Apr 15, 2024
ry
reviewed
Apr 15, 2024
ry
reviewed
Apr 15, 2024
marvinhagemeister
approved these changes
Apr 15, 2024
marvinhagemeister
approved these changes
Apr 17, 2024
|
🥂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various bugs, and introduces some features. Specifically:
/// <reference types="..." />work correctly now, especially when d.ts file is not a sibling of the JS file./// <reference types="..." />out of JS files correctly now.npm:andjsr:specifiers in user provided.d.tsfiles now.Fixes #367
Fixes #372
Fixes #364
Fixes #313
Fixes #180
Fixes #216
Fixes #326
Blocked on landing denoland/deno_ast#230 and denoland/deno_graph#429Landed