-
Notifications
You must be signed in to change notification settings - Fork 139
feat: add navigation menu for mobile #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! so happy to see this get cleaned up.
One thing I'd like to see fixed before we merge is how this handles using tab to navigate. Right now I can't seem to navigate to the items available in the dropdown by hitting tab unless the dropdown is already open. I would expect to be able to tab to the dropdown and open it to view the contents inside right after tab is focusing on Versions.
Mobile users won't necessarily see this but a lot of people use mobile viewport widths on their desktop to have reference docs alongside their editor so it would be nice to have this working for keyboard-only users in that setting.
While this does address the original problem, I'm concerned it creates another. I worry it isn't obvious that the This being the case, I would personally champion one of the following alternatives:
I'm open to other solutions I haven't considered as well, if they're intuitive enough. I just don't think the tradeoff here—saving some vertical real estate—is worth introducing a potentially confusing UI pattern. |
My $0.02 (not that anyone asked) is I like option 1. |
can focus and control by tab
I fixed the accessibility issue.
Option 1 is user-friendly on mobile, but it is very painful on PC because there is no mouse wheel for horizontal scrolling. |
close #40
If horizontal width of a navigation list exceeds a window size, it will store them in a small menu.
Preview
