fix: design update to Docs tab #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowlKats
approved these changes
Apr 30, 2024
crowlKats
reviewed
Apr 30, 2024
frontend/static/styles.css
Outdated
Comment on lines
263
to
266
| .ddoc .markdown_summary :not(pre) > code { | ||
| @apply bg-jsr-cyan-100/70 !important; | ||
| @apply px-1.5 !important; | ||
| } |
There was a problem hiding this comment.
actually this is problematic: inline code can have links, which are also blue
There was a problem hiding this comment.
updated to be a slightly lighter background so links pass contrast checks and wrote a style to apply link styles to links within markdown_summary (fix #451)
crowlKats
requested changes
Apr 30, 2024
crowlKats
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a long list of style changes affecting the Docs tab. I did them all in the jsr repo instead of ddoc because it was an easier dev workflow but it may be better to use this as a reference for what needs to change in deno_doc with the goal of eliminating nearly every
body .ddocstyle out of the stylesheet with the exception of any jsr theme colors.If we want to review and merge this we can but if we want to leave it as a TODO list and then close it out when deno_doc gets the updates, that's fine too.
also fixes #451