Skip to content

fix: update styles on symbol detail pages #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2024
Merged

Conversation

donjo
Copy link
Member

@donjo donjo commented May 2, 2024

First attempt at updating some of the styles on the symbol detail pages. I tried to leave some comments on bits where the thing I was changing could actually be fixed by applying a different tailwind class in deno_doc (like changing margin-top when I really want a space-y-3 to be a space-y-2

Same caveat as the last one, this could be used as a TODO list for changes that should happen back in deno_doc or merged in and used as a reference for refactoring later.

Example page of these styles on Oak/oak since that contains a large amount of varied text to format. (sidebar omitted from screenshot since that's changing in a different PR and I didn't want it to distract)
jsr test_@oak_oak_doc_~_Context

@donjo donjo requested review from lucacasonato and crowlKats May 2, 2024 15:43
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 60f9d38 May 10, 2024
8 checks passed
@crowlKats crowlKats deleted the johnd/symboldetail branch May 10, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants