Skip to content

fix: better warning when a package is yanked or pre-release #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024
Merged

fix: better warning when a package is yanked or pre-release #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f68b4
fix: better warning when a package is yanked
lucacasonato May 8, 2024
f88c444
update copy for pre-releases
lucacasonato May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions frontend/routes/package/(_components)/PackageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { CheckmarkStamp } from "../../../components/icons/CheckmarkStamp.tsx";
import { WarningTriangle } from "../../../components/icons/WarningTriangle.tsx";
import { Tooltip } from "../../../components/Tooltip.tsx";
import twas from "$twas";
import { parse } from "$std/semver/mod.ts";
import { gt, parse } from "$std/semver/mod.ts";

interface PackageHeaderProps {
package: Package;
Expand All @@ -20,8 +20,14 @@ export function PackageHeader(
const runtimeCompat = (
<RuntimeCompatIndicator runtimeCompat={pkg.runtimeCompat} />
);
const isPrerelease = selectedVersion &&
parse(selectedVersion.version).prerelease.length !== 0;
const isYanked = selectedVersion && selectedVersion.yanked;

const selectedVersionSemver = selectedVersion &&
parse(selectedVersion.version);
const isNewerPrerelease = selectedVersionSemver &&
selectedVersionSemver.prerelease.length !== 0 &&
(pkg.latestVersion === null ||
gt(selectedVersionSemver, parse(pkg.latestVersion)));

return (
<div class="space-y-6 mt-0 md:mt-4">
Expand All @@ -31,19 +37,26 @@ export function PackageHeader(
<div class="text-sm md:text-base flex items-center justify-center gap-4 md:gap-2">
<WarningTriangle class="text-jsr-yellow-400 flex-none" />
<span class="font-medium">
This release is{" "}
{isPrerelease && selectedVersion.newerVersionsCount == 0
This release {selectedVersion.yanked
? (
<>
was yanked — the latest version of @{pkg
.scope}/{pkg.name} is {pkg.latestVersion}.
</>
)
: isNewerPrerelease
? (
<>
a pre-release — the latest stable version of @{pkg
is a pre-release — the latest non-prerelease version of
@{pkg
.scope}/{pkg.name} is {pkg.latestVersion}.
</>
)
: (
<>
<span class="bold">
{selectedVersion.newerVersionsCount}{" "}
version{selectedVersion.newerVersionsCount > 1 && "s"}
is {selectedVersion.newerVersionsCount}{" "}
version{selectedVersion.newerVersionsCount !== 1 && "s"}
{" "}
behind {pkg.latestVersion}
</span>{" "}
Expand All @@ -54,9 +67,7 @@ export function PackageHeader(
class="link font-medium whitespace-nowrap"
href={`/@${pkg.scope}/${pkg.name}`}
>
Jump to latest{" "}
{isPrerelease && selectedVersion.newerVersionsCount == 0 &&
"stable"}
Jump to {isNewerPrerelease ? "this version " : "latest"}
</a>
</span>
</div>
Expand Down
Loading