Merge pull request #1365 from DianaSuvorova/i1288

[prop types] fix an assignment to prop

Author: ljharb

lib/rules/prop-types.js

@@ -116,6 +116,20 @@ module.exports = {
       return false;
     }
 
+    /**
+    * Checks if a prop is being assigned a value props.bar = 'bar'
+    * @param {ASTNode} node The AST node being checked.
+    * @returns {Boolean}
+    */
+
+    function isAssignmentToProp(node) {
+      return (
+        node.parent &&
+        node.parent.type === 'AssignmentExpression' &&
+        node.parent.left === node
+      );
+    }
+
     /**
      * Checks if we are using a prop
      * @param {ASTNode} node The AST node being checked.
@@ -126,7 +140,7 @@ module.exports = {
         (utils.getParentES6Component() || utils.getParentES5Component()) &&
         node.object.type === 'ThisExpression' && node.property.name === 'props'
       );
-      const isStatelessFunctionUsage = node.object.name === 'props';
+      const isStatelessFunctionUsage = node.object.name === 'props' && !isAssignmentToProp(node);
       const isNextPropsUsage = node.object.name === 'nextProps' && inComponentWillReceiveProps();
       return isClassUsage || isStatelessFunctionUsage || isNextPropsUsage;
     }

tests/lib/rules/prop-types.js

@@ -1557,7 +1557,18 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
-    }
+    },
+    // issue #1288
+    `function Foo() {
+      const props = {}
+      props.bar = 'bar'
+      return <div {...props} />
+    }`,
+    // issue #1288
+    `function Foo(props) {
+      props.bar = 'bar';
+      return <div {...props} />;
+    }`
   ],
 
   invalid: [