Skip to content

Commit 953e858

Browse files
author
Yannick Croissant
committed
Add test to check jsx-uses-vars and prefer-const compatibility (#716)
1 parent 33a3516 commit 953e858

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

tests/lib/rules/jsx-uses-vars.js

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
// -----------------------------------------------------------------------------
1111

1212
var eslint = require('eslint').linter;
13-
var rule = require('eslint/lib/rules/no-unused-vars');
13+
var ruleNoUnusedVars = require('eslint/lib/rules/no-unused-vars');
14+
var rulePreferConst = require('eslint/lib/rules/prefer-const');
1415
var RuleTester = require('eslint').RuleTester;
1516

1617
var parserOptions = {
@@ -28,7 +29,7 @@ require('babel-eslint');
2829

2930
var ruleTester = new RuleTester();
3031
eslint.defineRule('jsx-uses-vars', require('../../../lib/rules/jsx-uses-vars'));
31-
ruleTester.run('no-unused-vars', rule, {
32+
ruleTester.run('no-unused-vars', ruleNoUnusedVars, {
3233
valid: [
3334
{
3435
code: '\
@@ -186,3 +187,25 @@ ruleTester.run('no-unused-vars', rule, {
186187
}
187188
]
188189
});
190+
191+
// Check compatibility with eslint prefer-const rule (#716)
192+
ruleTester.run('prefer-const', rulePreferConst, {
193+
valid: [],
194+
invalid: [{
195+
code: [
196+
'/* eslint jsx-uses-vars:1 */',
197+
'let App = <div />;',
198+
'<App />;'
199+
].join('\n'),
200+
errors: [{message: '\'App\' is never reassigned. Use \'const\' instead.'}],
201+
parserOptions: parserOptions
202+
}, {
203+
code: [
204+
'/* eslint jsx-uses-vars:1 */',
205+
'let filters = \'foo\';',
206+
'<div>{filters}</div>;'
207+
].join('\n'),
208+
errors: [{message: '\'filters\' is never reassigned. Use \'const\' instead.'}],
209+
parserOptions: parserOptions
210+
}]
211+
});

0 commit comments

Comments
 (0)