Skip to content

handling a nil panic pointer causing a node to be removed #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

handling a nil panic pointer causing a node to be removed #2604

wants to merge 1 commit into from

Conversation

jemershaw
Copy link

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #2597

@review-ai-agent review.ai agent
Copy link

review-ai-agent bot commented May 15, 2025 •
edited
Loading

Pull Request Revisions

RevisionDescription
r1
Added nil check for nodeAdded a defensive nil check for m.node before calling RemoveNode to prevent potential nil pointer dereference
☑️ AI review skipped for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont Awaiting requested review from juanfont juanfont will be requested when the pull request is marked ready for review juanfont is a code owner

@kradalby kradalby Awaiting requested review from kradalby kradalby will be requested when the pull request is marked ready for review kradalby is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] node randomly gets removed due to a panic
1 participant
@jemershaw