Skip to content

Commit 4d7590c

Browse files
committed
Enable NeoForge module
It seems that the mod initializer now runs before a Minecraft instance exists, so all static Minecraft fields had to be removed. Signed-off-by: Lilly Rose Berner <lilly@lostluma.net>
1 parent e2fe369 commit 4d7590c

File tree

8 files changed

+20
-13
lines changed

8 files changed

+20
-13
lines changed

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ minecraft_version = 1.21.5
1818
minecraft_version_min = 1.21.5
1919
minecraft_version_max = 1.21.5
2020

21-
enabled_platforms=fabric,quilt
21+
enabled_platforms=fabric,neoforge,quilt

gradle/libs.versions.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ fabric_api = "0.118.2+1.21.5"
88

99
forge = "1.21.3-53.0.7"
1010

11-
neoforge = "21.3.0-beta"
11+
neoforge = "21.5.2-beta"
1212

1313
quilt_loader = "0.25.0"
1414

@@ -24,7 +24,7 @@ cloth_config = "15.0.127"
2424
mixinextras = "0.4.1"
2525

2626
architectury = "3.4.161"
27-
architectury_loom = "1.9.428"
27+
architectury_loom = "1.10.429"
2828

2929
mod_publish = "0.8.4"
3030

platforms/common/src/main/java/dynamic_fps/impl/DynamicFPSMod.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ public class DynamicFPSMod {
4444
private static boolean isForcingLowFPS = false;
4545
private static boolean isKeybindDisabled = false;
4646

47-
private static final Minecraft minecraft = Minecraft.getInstance();
48-
4947
private static @Nullable WindowObserver window;
5048
private static @Nullable ClickIgnoreHandler clickHandler;
5149

@@ -251,11 +249,14 @@ private static void showNotification(String titleTranslationKey, String iconPath
251249
}
252250

253251
private static boolean isLevelCoveredByOverlay() {
252+
Minecraft minecraft = Minecraft.getInstance();
254253
return OVERLAY_OPTIMIZATION_ACTIVE && minecraft.getOverlay() instanceof LoadingOverlay && ((DuckLoadingOverlay)minecraft.getOverlay()).dynamic_fps$isReloadComplete();
255254
}
256255

257256
@SuppressWarnings("squid:S1215") // Garbage collector call
258257
public static void handleStateChange(PowerState previous, PowerState current) {
258+
Minecraft minecraft = Minecraft.getInstance();
259+
259260
if (Constants.DEBUG) {
260261
Logging.getLogger().info("State changed from {} to {}.", previous, current);
261262
}
@@ -289,6 +290,8 @@ public static void handleStateChange(PowerState previous, PowerState current) {
289290
}
290291

291292
private static void checkForStateChanges() {
293+
Minecraft minecraft = Minecraft.getInstance();
294+
292295
if (window == null) {
293296
return;
294297
}

platforms/common/src/main/java/dynamic_fps/impl/compat/GLFW.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import net.minecraft.client.Minecraft;
77

88
public class GLFW {
9-
private static final Minecraft minecraft = Minecraft.getInstance();
109
private static final boolean enterEventBroken = isEnterEventBroken();
1110

1211
/**
@@ -18,6 +17,8 @@ public class GLFW {
1817
* Dynamic FPS releases and captures the cursor in tandem with window focus.
1918
*/
2019
public static void applyWorkaround() {
20+
Minecraft minecraft = Minecraft.getInstance();
21+
2122
if (!useWorkaround()) {
2223
return;
2324
}
@@ -38,6 +39,7 @@ public static void applyWorkaround() {
3839
}
3940

4041
private static boolean useWorkaround() {
42+
Minecraft minecraft = Minecraft.getInstance();
4143
return enterEventBroken && minecraft.screen == null && !minecraft.options.pauseOnLostFocus;
4244
}
4345

platforms/common/src/main/java/dynamic_fps/impl/feature/state/ClickIgnoreHandler.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ public class ClickIgnoreHandler {
1616
private final GLFWWindowFocusCallback previousFocusCallback;
1717
private final GLFWMouseButtonCallback previousClickCallback;
1818

19-
private static final Minecraft MINECRAFT = Minecraft.getInstance();
20-
2119
public ClickIgnoreHandler(long address) {
2220
this.address = address;
2321

@@ -30,13 +28,14 @@ public static boolean isFeatureActive() {
3028
}
3129

3230
private boolean shouldIgnoreClick() {
31+
Minecraft minecraft = Minecraft.getInstance();
3332
IgnoreInitialClick config = DynamicFPSConfig.INSTANCE.ignoreInitialClick();
3433

3534
if (config == IgnoreInitialClick.DISABLED) {
3635
return false;
3736
}
3837

39-
if (config == IgnoreInitialClick.IN_WORLD && MINECRAFT.screen != null) {
38+
if (config == IgnoreInitialClick.IN_WORLD && minecraft.screen != null) {
4039
return false;
4140
}
4241

platforms/common/src/main/java/dynamic_fps/impl/feature/volume/SmoothVolumeHandler.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public class SmoothVolumeHandler {
1515
private static boolean active = false;
1616
private static boolean needsUpdating = false;
1717

18-
private static final Minecraft minecraft = Minecraft.getInstance();
1918
private static final Map<SoundSource, Float> currentOverrides = new HashMap<>();
2019

2120
public static void init() {
@@ -77,6 +76,7 @@ private static void tickVolumes() {
7776

7877
private static void updateVolume(SoundSource source) {
7978
// Update volume of currently playing sounds
79+
Minecraft minecraft = Minecraft.getInstance();
8080
((DuckSoundEngine) minecraft.getSoundManager().soundEngine).dynamic_fps$updateVolume(source);
8181
}
8282
}

platforms/common/src/main/java/dynamic_fps/impl/util/HudInfoRenderer.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
import dynamic_fps.impl.DynamicFPSMod;
1414

1515
public final class HudInfoRenderer {
16-
private static final Minecraft minecraft = Minecraft.getInstance();
17-
1816
public static void renderInfo(GuiGraphics guiGraphics) {
17+
Minecraft minecraft = Minecraft.getInstance();
18+
1919
if (minecraft.options.hideGui || minecraft.screen != null) {
2020
return;
2121
}
@@ -33,11 +33,14 @@ public static void renderInfo(GuiGraphics guiGraphics) {
3333

3434
private static void drawCenteredText(GuiGraphics guiGraphics, Component component) {
3535
int width = guiGraphics.guiWidth() / 2;
36+
Minecraft minecraft = Minecraft.getInstance();
3637

3738
guiGraphics.drawCenteredString(minecraft.font, component, width, 32, 0xFFFFFF);
3839
}
3940

4041
private static void drawBatteryOverlay(GuiGraphics graphics) {
42+
Minecraft minecraft = Minecraft.getInstance();
43+
4144
if (minecraft.getDebugOverlay().showDebugScreen() || !BatteryTracker.hasBatteries()) {
4245
return;
4346
}

settings.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ includeBuild("build-logic")
1818
include(":platforms:common")
1919
include(":platforms:fabric")
2020
// include(":platforms:forge")
21-
// include(":platforms:neoforge")
21+
include(":platforms:neoforge")
2222
include(":platforms:quilt")
2323
include(":platforms:textile")

0 commit comments

Comments
 (0)