Fix ConcurrentModificationException updating sound volumes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lilly Rose Berner <lilly@lostluma.net>
LostLuma
force-pushed
the
fix/sound-engine-concurrent-modification
branch
from
1a3c63a to
2af9c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #220
Resolves #224
Resolves #250
Instead of iterating over the map of active sounds we now take a copy of the keys, iterate over that, and manually get the values from the map, checking for missing ones. This should make it impossible for a key/value pair being removed from the map in the background to throw a
ConcurrentModificationException.